[WIP] Issue dashboard: add filter by label name #19304
Open
+84
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- dedup & unify logic - make sure allow / deny list works
as the issue search query is complicated already, I added the label search as a separate query. It's also non-trivial, as a user can have access to various label sets, which may contain different labels with the same name. TODO: - Add a proper frontend for this. dropdown like on repo issue listing is not an option, as labels will be duplicated across repos. Maybe extend q= with lucene-style syntax `label:foo -label:bar` - Preserve &labels= and &label-names= on sidebar button links.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the option to filter issues by label names in the issue dashboard via query parameter.
As of now, this is lacking a frontend, as it's unclear to me how a GUI (eg a dropdown as in the repo issue list) would deal with duplicate labels across repos.
A good option could be to add lucene-style search syntax to the current keyword search field (eg
label:foo -label:bar).It feels a bit hacky to have two filters for labels, once by label ID, and once by label name.
This is caused by the duality of exposing label-instances to the user, while users refer to them only by name (see #14012).
I propose to gradually to remove user-facing label IDs, this PR could be a first step along that line. (A next step would be a de-duplication layer for available labels (for a repo & for a user). Using that, user-facing interfaces could start referencing labels by name.)
This also fixes 2 bugs I found along the way, I'll separate them out of this PR later.
TODO
&labels=&&label-names=params to sidebar buttonspartially fixes #791