Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a UI error when folding a file content in a commit view #17446

Merged
merged 2 commits into from
Oct 27, 2021
Merged

Fix a UI error when folding a file content in a commit view #17446

merged 2 commits into from
Oct 27, 2021

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang added issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change topic/ui Change the appearance of the Gitea UI skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Oct 27, 2021
@wxiaoguang wxiaoguang added this to the 1.16.0 milestone Oct 27, 2021
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 27, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 27, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 27, 2021
@lunny lunny merged commit 89becee into go-gitea:main Oct 27, 2021
@wxiaoguang wxiaoguang deleted the fix-commit-file-fold branch October 27, 2021 11:16
@silverwind
Copy link
Member

This change seems to have broken file folding in the diff view, e.g. clicking the chevron on https://try.gitea.io/silverwind/remap-css/commit/a0f5a9a9c6958455c818eecba2199846a96b2612 gives error:

TypeError: can't access property "innerHTML", i is null

@wxiaoguang
Copy link
Contributor Author

This change seems to have broken file folding in the diff view, e.g. clicking the chevron on https://try.gitea.io/silverwind/remap-css/commit/a0f5a9a9c6958455c818eecba2199846a96b2612 gives error:

TypeError: can't access property "innerHTML", i is null

@silverwind The PR #16829 broke the file folding in the diff view, this PR fixes it. This PR hasn't been deployed to try.gitea.io .

@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented Oct 27, 2021 •
edited
Loading

This change seems to have broken file folding in the diff view, e.g. clicking the chevron on https://try.gitea.io/silverwind/remap-css/commit/a0f5a9a9c6958455c818eecba2199846a96b2612 gives error:

TypeError: can't access property "innerHTML", i is null

@silverwind The PR #16829 broke the file folding in the diff view, this PR fixes it. This PR hasn't been deployed to try.gitea.io .

@silverwind You can try it on try.gitea.io now, the latest deployment is done, the bug is fixed, at least it works for me. (Remember to clear HTTP cache)

@silverwind
Copy link
Member

Indeed, it's working now. Sorry I thought it had already deployed :)

Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@wxiaoguang
Fix a UI error when folding a file content in a commit view (go-gitea…
cb8221c 
…#17446)
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.

UI error when viewing a commit (clicking the down arrow)
5 participants
@wxiaoguang @silverwind @lunny @delvh @GiteaBot