Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow mocking timeutil #17354

Merged
merged 1 commit into from
Oct 18, 2021
Merged

Allow mocking timeutil #17354

merged 1 commit into from
Oct 18, 2021

Conversation

jolheiser
Copy link
Member

This should allow us to avoid the heatmap issues in our tests.

A better mocking system may need to be implemented in the future, this is still somewhat bandaid.

@jolheiser
Allow mocking timeutil
704b1a6 
Signed-off-by: jolheiser <john.olheiser@gmail.com>
@jolheiser jolheiser added type/testing skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. backport/v1.15 labels Oct 18, 2021
@jolheiser jolheiser added this to the 1.16.0 milestone Oct 18, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 18, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 18, 2021
@zeripath zeripath merged commit c59afa7 into go-gitea:main Oct 18, 2021
@zeripath
Copy link
Contributor

Please send backport

jolheiser added a commit to jolheiser/gitea that referenced this pull request Oct 18, 2021
@jolheiser
Allow mocking timeutil (go-gitea#17354)
ef71be7 
Signed-off-by: jolheiser <john.olheiser@gmail.com>
# Conflicts:
#	models/user_heatmap_test.go
@jolheiser jolheiser mentioned this pull request Oct 18, 2021
Merged
jolheiser added a commit that referenced this pull request Oct 18, 2021
@jolheiser
Allow mocking timeutil (#17354) (#17356)
eb748ff 
Signed-off-by: jolheiser <john.olheiser@gmail.com>
@zeripath zeripath added the backport/done All backports for this PR have been created label Oct 20, 2021
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@jolheiser
Allow mocking timeutil (go-gitea#17354)
11ea966 
Signed-off-by: jolheiser <john.olheiser@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/testing
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jolheiser @zeripath @techknowlogick @GiteaBot