-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sanitation fix from Gogs #1461
Merged
Merged
Sanitation fix from Gogs #1461
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
a242510
Santiation fix from Gogs
bkcsoft fa24b11
Linting
bkcsoft 09e7acd
Fix build-errors
bkcsoft 20a883d
still not working
bkcsoft c16b762
Fix all the things!
bkcsoft 15f0a40
gofmt
bkcsoft d5b711b
Add code-injection checks
bkcsoft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,7 +13,7 @@ import ( | |
|
||
"github.com/microcosm-cc/bluemonday" | ||
|
||
"github.com/gogits/gogs/modules/setting" | ||
"code.gitea.io/gitea/modules/setting" | ||
) | ||
|
||
// Sanitizer is a protection wrapper of *bluemonday.Policy which does not allow | ||
|
@@ -48,10 +48,19 @@ func NewSanitizer() { | |
|
||
// Sanitize takes a string that contains a HTML fragment or document and applies policy whitelist. | ||
func Sanitize(s string) string { | ||
if sanitizer == nil { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It seems a race problem? |
||
NewSanitizer() | ||
} | ||
return sanitizer.policy.Sanitize(s) | ||
} | ||
|
||
// SanitizeBytes takes a []byte slice that contains a HTML fragment or document and applies policy whitelist. | ||
func SanitizeBytes(b []byte) []byte { | ||
if len(b) == 0 { | ||
return []byte{} | ||
} | ||
if sanitizer == nil { | ||
NewSanitizer() | ||
} | ||
return sanitizer.policy.SanitizeBytes(b) | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merge the gitea internal packages.