Ensure template renderer is available before storage handler (#13164) #13982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ctx.Error` requires that templates are available for this to render the error page otherwise there will be a panic at this time. This was fixed in go-gitea#13164 but was not completely backported. Fix go-gitea#13971 Signed-off-by: Andrew Thornton <art27@cantab.net>
6543
approved these changes
Dec 14, 2020
lunny
approved these changes
Dec 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ctx.Errorrequires that templates are available for this torender the error page otherwise there will be a panic at this
time.
This was fixed in #13164 but was not completely backported.
Fix #13971
Signed-off-by: Andrew Thornton art27@cantab.net