Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vendor] Update go-ldap to v3.2.4 #13163

Merged
merged 3 commits into from
Oct 15, 2020
Merged

[Vendor] Update go-ldap to v3.2.4 #13163

merged 3 commits into from
Oct 15, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Oct 15, 2020 •
edited
Loading

go get -u had an issue with it, this fix it :)

@6543 6543 added this to the 1.14.0 milestone Oct 15, 2020
@techknowlogick techknowlogick added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Oct 15, 2020
techknowlogick
techknowlogick reviewed Oct 15, 2020
View reviewed changes
Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it is v3 you'll need to reference github.com/go-ldap/ldap/v3

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 15, 2020
@codecov-io
Copy link

codecov-io commented Oct 15, 2020 •
edited
Loading

Codecov Report

Merging #13163 into master will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13163      +/-   ##
==========================================
- Coverage   42.08%   41.94%   -0.15%     
==========================================
  Files         681      681              
  Lines       75121    75121              
==========================================
- Hits        31613    31506     -107     
- Misses      38357    38492     +135     
+ Partials     5151     5123      -28
Impacted Files Coverage Δ
modules/auth/ldap/ldap.go 46.81% <ø> (ø)
modules/indexer/stats/db.go 43.47% <0.00%> (-17.40%) ⬇️
services/pull/check.go 35.76% <0.00%> (-13.14%) ⬇️
modules/indexer/stats/queue.go 64.70% <0.00%> (-11.77%) ⬇️
modules/notification/ui/ui.go 72.22% <0.00%> (-8.34%) ⬇️
models/issue_comment.go 45.71% <0.00%> (-7.22%) ⬇️
modules/notification/mail/mail.go 28.73% <0.00%> (-5.75%) ⬇️
modules/git/commit.go 50.00% <0.00%> (-4.06%) ⬇️
modules/notification/base/null.go 68.57% <0.00%> (-2.86%) ⬇️
modules/notification/notification.go 78.57% <0.00%> (-2.68%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25f7e1c...67cb89b. Read the comment docs.

@6543 6543 changed the title [Vendor] Update go-ldap to v3.0.3 [Vendor] Update go-ldap to v3.2.4 Oct 15, 2020
@6543 6543 requested a review from techknowlogick October 15, 2020 17:35
@6543
Copy link
Member Author

6543 commented Oct 15, 2020

@techknowlogick somehow missed that ... now it works as it should :)

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 15, 2020
techknowlogick
techknowlogick reviewed Oct 15, 2020
View reviewed changes
Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

somehow missed that ...

no worries. I just made this same upgrade in another project so I was recently aware of it.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 15, 2020
@techknowlogick techknowlogick merged commit e374bb7 into go-gitea:master Oct 15, 2020
@6543 6543 deleted the vendor_go-ldap branch October 15, 2020 19:45
ivanvc added a commit to ivanvc/gitea that referenced this pull request Oct 16, 2020
@ivanvc
Merge remote-tracking branch 'origin/master' into update-outdated-com…
65328d9 
…ments-in-pull-request-label-style

* origin/master:
  [skip ci] Updated translations via Crowdin
  Fix diff skipping lines (go-gitea#13154)
  Update go-version v1.2.3 -> v1.2.4 (go-gitea#13169)
  Vendor Update Go Libs (go-gitea#13166)
  Prevent panics with missing storage (go-gitea#13164)
  Improve users management through the CLI (go-gitea#6001) (go-gitea#10492)
  Change order of possible-owner organizations to alphabetical (go-gitea#13160)
  Slightly simplify the queue settings code to help reduce the risk of problems (go-gitea#12976)
  [Vendor] Update go-ldap to v3.2.4 (go-gitea#13163)
  [skip ci] Updated translations via Crowdin
  Update external-renderers.en-us.md (go-gitea#13165)
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.
5 participants
@6543 @codecov-io @techknowlogick @zeripath @GiteaBot