Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slight simplification of accessibleRepositoryCondition #10875

Merged
merged 4 commits into from
Mar 29, 2020
Merged

Slight simplification of accessibleRepositoryCondition #10875

merged 4 commits into from
Mar 29, 2020

Conversation

zeripath
Copy link
Contributor

Very slight simplification of accessibleRepositoryCondition - remove one of the In queries.

Signed-off-by: Andrew Thornton art27@cantab.net

@zeripath
Slight simplification of accessibleRepositoryCondition
fb4b1dd 
Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added the type/enhancement An improvement of existing functionality label Mar 29, 2020
@zeripath zeripath added this to the 1.12.0 milestone Mar 29, 2020
@lunny
Copy link
Member

lunny commented Mar 29, 2020

It looks good, but why CI failed.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 29, 2020
@zeripath
Copy link
Contributor Author

zeripath commented Mar 29, 2020 •
edited
Loading

I suspect it's unrelated and may be related to the start of summertime in many places?

Nope - continuing the good old De Morgan's law theme...

zeripath
zeripath commented Mar 29, 2020
View reviewed changes
models/repo_list.go Outdated Show resolved Hide resolved
zeripath
zeripath commented Mar 29, 2020
View reviewed changes
models/repo_list.go Outdated Show resolved Hide resolved
zeripath
zeripath commented Mar 29, 2020
View reviewed changes
models/repo_list.go Outdated Show resolved Hide resolved
@lafriks lafriks added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Mar 29, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 29, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 29, 2020
@zeripath
Copy link
Contributor Author

make lg-tm work

@zeripath zeripath merged commit 209045f into go-gitea:master Mar 29, 2020
@zeripath zeripath deleted the slight-simplification-accessible-repo-subquery branch March 29, 2020 14:31
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@mrsdizzie mrsdizzie mrsdizzie approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
5 participants
@zeripath @lunny @lafriks @mrsdizzie @GiteaBot