-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for #828: Embed build tags #1051
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,6 +8,7 @@ package main // import "code.gitea.io/gitea" | |
|
||
import ( | ||
"os" | ||
"strings" | ||
|
||
"code.gitea.io/gitea/cmd" | ||
"code.gitea.io/gitea/modules/log" | ||
|
@@ -18,15 +19,18 @@ import ( | |
// Version holds the current Gitea version | ||
var Version = "1.1.0+dev" | ||
|
||
// Tags holds the build tags used | ||
var Tags = "" | ||
|
||
func init() { | ||
setting.AppVer = Version | ||
setting.AppVer = Version + formatBuiltWith(Tags) | ||
} | ||
|
||
func main() { | ||
app := cli.NewApp() | ||
app.Name = "Gitea" | ||
app.Usage = "A painless self-hosted Git service" | ||
app.Version = Version | ||
app.Version = Version + formatBuiltWith(Tags) | ||
app.Commands = []cli.Command{ | ||
cmd.CmdWeb, | ||
cmd.CmdServ, | ||
|
@@ -42,3 +46,11 @@ func main() { | |
} | ||
|
||
} | ||
|
||
func formatBuiltWith(Tags string) string { | ||
if len(Tags) == 0 { | ||
return "" | ||
} | ||
|
||
return " built with: " + strings.Replace(Tags, " ", ", ", -1) | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. strings.Join There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Tags is There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. True, but maybe it's even easier to create a comma separated list to split by space and join by comma |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be done with a separate variable, IMHO we should not list the build tags on every page in the footer, only within the admin dashboard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, I missed that!