Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid mailer.FROM causes the installation to fail. #27188

Closed
Violet-VE opened this issue Sep 22, 2023 · 1 comment · Fixed by #29347
Closed

Invalid mailer.FROM causes the installation to fail. #27188

Violet-VE opened this issue Sep 22, 2023 · 1 comment · Fixed by #29347
Assignees
Labels
Milestone

Comments

@Violet-VE
Copy link

Violet-VE commented Sep 22, 2023

Description

Because I have not been able to complete the installation, and then looked at the running status of gitea and realized:
Invalid mailer.FROM (Violet-VE): mail: missing '@' or angle-addr

But he didn't prompt me when I was filling out the form.

Okay, I admit I missed the hint at the bottom, but it doesn't make sense that he doesn't have form validation!

Gitea Version

1.20.4

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

systemctl start gitea

Database

MySQL/MariaDB

@carlosfelgueiras
Copy link
Contributor

Just reproduced this. I will work on it.

carlosfelgueiras added a commit to carlosfelgueiras/gitea that referenced this issue Feb 23, 2024
carlosfelgueiras added a commit to carlosfelgueiras/gitea that referenced this issue Feb 23, 2024
6543 pushed a commit that referenced this issue Feb 23, 2024
Fixes #27188.
Introduces a check on the installation that tries to parse the FROM
address. If it fails, shows a new error message to the user.

---------

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
@lunny lunny added this to the 1.21.7 milestone Feb 24, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Feb 24, 2024
)

Fixes go-gitea#27188.
Introduces a check on the installation that tries to parse the FROM
address. If it fails, shows a new error message to the user.

---------

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
lunny pushed a commit that referenced this issue Feb 24, 2024
…9360)

Backport #29347 by @carlosfelgueiras

Fixes #27188.
Introduces a check on the installation that tries to parse the FROM
address. If it fails, shows a new error message to the user.

Co-authored-by: Carlos Felgueiras <carlosfelgueiras@tecnico.ulisboa.pt>
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2024
project-mirrors-bot-tu bot pushed a commit to project-mirrors/forgejo-as-gitea-fork that referenced this issue Jan 23, 2025
) (go-gitea#29360)

Backport go-gitea#29347 by @carlosfelgueiras

Fixes go-gitea#27188.
Introduces a check on the installation that tries to parse the FROM
address. If it fails, shows a new error message to the user.

Co-authored-by: Carlos Felgueiras <carlosfelgueiras@tecnico.ulisboa.pt>
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
(cherry picked from commit 35db5a3)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants