-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to use Manually Configured OAuth with Git Credentials Manager #26526
Comments
|
Oops, I thought it's about the "builtin" Git Credentials Manager support, but it's not, reopen.
What's the URI? |
Thanks for reopening, my apologies as I probably could've been clearer. As to the URI the redirect URI setup with Gitea is: A example of the request (copied directly from an actual attempt to use GCM) is as follows: This fails. However the following works: |
Ignore the trailing slashes when comparing oauth2 redirect_uri #26597 |
… (#26618) Backport #26597 by @wxiaoguang Fix #26526 Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
…tea#26597) (go-gitea#26618) Backport go-gitea#26597 by @wxiaoguang Fix go-gitea#26526 Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> (cherry picked from commit 4aed0e6)
Description
Whenever using generic oauth authentication with Gitea, git-credentials-manager can not actually use gitea's oauth implementation. This occurs because the git-credentials-manager appends a trailing backslash onto the URI causing gitea to give an
unauthorized_client: unexpected redirect URI
error. This completely stops me from being able to use GCM with Gitea with how I have it setup atm.Ideally, gitea should not care about trailing backslashes.
Gitea Version
1.20.2
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Screenshots
No response
Git Version
No response
Operating System
No response
How are you running Gitea?
Gitea provided windows release of 1.20.2 and on https://try.gitea.io
Database
None
The text was updated successfully, but these errors were encountered: