Issue - heatmap is mini-heatmap #13634
Comments
|
@silverwind some sort of chrome css incompatiblety? |
I already did... |
|
@wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf sorry - didnt read the " ... chrome ..." the first time ... |
no worries. |
|
I think I only tested this in Firefox if I recall correctly. |
Apparently SVG inside flexbox renders slightly different across browsers where Firefox would stretch to fit the parent while Chrome and safari wouldn't. Stretch the SVG to the width of the parent for consistent rendering. Also did a few minor tweaks on the min-height of the box so it takes up less space on smaller responsive breakpoints. Fixes: go-gitea#13634 Fixes: go-gitea#13637
Apparently SVG inside flexbox renders slightly different across browsers where Firefox would stretch to fit the parent while Chrome and safari wouldn't. Stretch the SVG to the width of the parent for consistent rendering. Also did a few minor tweaks on the min-height of the box so it takes up less space on smaller responsive breakpoints. Fixes: go-gitea#13634 Fixes: go-gitea#13637
|
Any chance #13645 be merged soon? I'd be happy with the current heatmap if I was an ant right now, but since I am not... 🙂 |
for now, you could build Gitea with the patch (that's what I've done)... cd gitea-src-folder
curl -O https://patch-diff.githubusercontent.com/raw/go-gitea/gitea/pull/13645.patch
git am 13645
make build # specify desired TAGS before this...edit silly typo: |
* Fix heatmap rendering in Chrome and Safari Apparently SVG inside flexbox renders slightly different across browsers where Firefox would stretch to fit the parent while Chrome and safari wouldn't. Stretch the SVG to the width of the parent for consistent rendering. Also did a few minor tweaks on the min-height of the box so it takes up less space on smaller responsive breakpoints. Fixes: #13634 Fixes: #13637 * position tweak Co-authored-by: zeripath <art27@cantab.net>
Gitea version 1.14.0+dev-239-gad2a28862 built with GNU Make 4.3, go1.15.5 : bindata, sqlite, sqlite_unlock_notifygit version 2.29.2.497.ga2da47d1e7Description
Appears to be introduced by #13623 .
The issue is that the heatmap appears really small.
I have tried to reproduce it in chromium, firefox and brave (chromium-based) and this issue only pertains in chromium (consistently).
For the user dashboard to pop up you have to be logged in, in chromium, though, you can also see the issue when navigating to user's 'Public Activity' page (https://try.gitea.io/kjhfdskahhjksdf?tab=activity), for which you, obviously, don't have to be logged in.
Screenshots
my instance
try.gitea.io logged in (Public Activity) pic1
try.gitea.io logged in (dashboard) pic2
try.gitea.io logged out (activity)
edit: missing parenthesis (image not showing properly)
edit2: add blame
The text was updated successfully, but these errors were encountered: