gitea docker image have bugs

[vtolstov]

"Id": "sha256:79bdd2b180885b6f7ef56cabf78201b7a3afc86f4cc74f3ccd23b8ed56a4c446",
"gitea/gitea@sha256:8f59c1e816313418824ad171bc349e9843e527a4b1c1ff6f2f462a9d4987fae3"

template: repo/issue/view_content/comments:189:105: executing "repo/issue/view_content/comments" at <RenderLabels .AddedLabels>: error calling RenderLabels: runtime error: invalid memory address or nil pointer dereference

issue had some labels attached , as i understand this related to kanban board changes, i'm move issues to in progress board.
issues without attaching to project does not have this problem

[vtolstov]

docker[442729]: 2020/11/12 07:34:21 ...els/issue_comment.go:383:LoadLabel() [W] Commit 705 cannot load label 0

[vtolstov]

i'm not delete any labels and this issue with error not displayed in kanban board =(

[vtolstov]

@lunny can you helps with this? Mostly i cant work with around 20issues in my repo now because of such error.

[lunny]

@vtolstov Do you have customize templates? And what's the Gitea version of the docker?

[vtolstov]

I dont customize any templates, but have custom label set.
Gitea 1.14.0+dev-200-g0ae35c66f

[vtolstov]

I have one template for mermeid footer.tmpl thats adds javascript code.

[lunny]

It seems this cannot be reproduced in https://try.gitea.io which will always follow the latest docker image.

[6543]

wasn't mermeid integrated?

[6543]

I ... have custom label set.

can you show us how they look like?

[vtolstov]

https://gist.github.com/vtolstov/e7c9176cf52d245c2a9fe857e4afb6a1 This is my labels сб, 14 нояб. 2020 г., 16:50 6543 <notifications@github.com>:

…

I ... have custom label set. can you show us how they look like? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#13516 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADVQG62BTPAACIJVPHNQB3SP2DKRANCNFSM4TSFDJCQ> .

[vtolstov]

I do this before it has been integrated. сб, 14 нояб. 2020 г., 16:49 6543 <notifications@github.com>:

…

wasn't mermeid integrated? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#13516 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADVQG4A3DHHADC3JOAKS5DSP2DFNANCNFSM4TSFDJCQ> .

[6543]

ok this file works ... so it should not cause any issue on your side too

[vtolstov]

So, how can i debug issue? Via gitnex client on android i can display issue on my phone withou problems, so this is not error in db сб, 14 нояб. 2020 г., 22:06 6543 <notifications@github.com>:

…

ok this file works ... so it should not cause any issue on your side too — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#13516 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADVQG3KAESBW2KKYDLG42TSP3IKXANCNFSM4TSFDJCQ> .

[vtolstov]

i'm copy template from git to custom templates dir and remove block for labels from 189 line. now issue is displayed
but as you see - in labels i have empty lines, may be issue have some labels that not present now?

[vtolstov]

[vtolstov]

for example:

"RenderLabels": func(labels []*models.Label) template.HTML {                                         
  html := ""                                                                                         
                                                                                                     
  for _, label := range labels {                                                                     
    html = fmt.Sprintf("%s<div class='ui label' style='color: %s; background-color: %s'>%s</div>",   
      html, label.ForegroundColor(), label.Color, RenderEmoji(label.Name))                           
  }                                                                                                  
                                                                                                     
  return template.HTML(html)                                                                         
},                                                                                                   

receives nil Label, so func try to dereference nil struct field and crushes?

[vtolstov]

i'm dump label table from db and it looks strange - it contains duplicate label names...
https://gist.github.com/vtolstov/d5599c4f383a5b8047a5f7669110aa9e

[lunny]

@vtolstov For different repository, the duplicated labels are allowed. For one repository, that should be not.

[vtolstov]

@vtolstov For different repository, the duplicated labels are allowed. For one repository, that should be not.

Ok, what next?as i understand problem on labels some label not valud struct pointer and accesd to member fails

[lunny]

This maybe related with #13304

[lunny]

I suspect the problem is in https://github.com/go-gitea/gitea/pull/13304/files#diff-48c8791f86b36b38bb6d8c33cbf71ecda001cf5985ad99c66b99541afbe21169R2392.

[vtolstov]

any chance to get this fixed ? =)