Skip to content

Commit

Permalink
Don't display creating page button in a mirror wiki repository (#24395)
Browse files Browse the repository at this point in the history
A mirror repository with wiki is also a mirror. So creating page from UI
should be disabled. This PR hides the button like other places.
  • Loading branch information
lunny authored May 4, 2023
1 parent 5d77691 commit b1cee3f
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions options/locale/locale_en-US.ini
Original file line number Diff line number Diff line change
Expand Up @@ -1904,6 +1904,7 @@ settings.sync_mirror = Synchronize Now
settings.mirror_sync_in_progress = Mirror synchronization is in progress. Check back in a minute.
settings.site = Website
settings.update_settings = Update Settings
settings.update_mirror_settings = Update Mirror Settings
settings.branches.switch_default_branch = Switch Default Branch
settings.branches.update_default_branch = Update Default Branch
settings.branches.add_new_rule = Add New Rule
Expand Down
2 changes: 1 addition & 1 deletion templates/repo/settings/options.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@
</div>
{{end}}
<div class="field">
<button class="ui green button">{{$.locale.Tr "repo.settings.update_settings"}}</button>
<button class="ui green button">{{$.locale.Tr "repo.settings.update_mirror_settings"}}</button>
</div>
</form>
</td>
Expand Down
2 changes: 1 addition & 1 deletion templates/repo/wiki/pages.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<h2 class="ui header gt-df gt-ac gt-sb">
<span>{{.locale.Tr "repo.wiki.pages"}}</span>
<span>
{{if and .CanWriteWiki (not .IsRepositoryMirror)}}
{{if and .CanWriteWiki (not .Repository.IsMirror)}}
<a class="ui green small button" href="{{.RepoLink}}/wiki?action=_new">{{.locale.Tr "repo.wiki.new_page_button"}}</a>
{{end}}
</span>
Expand Down

0 comments on commit b1cee3f

Please sign in to comment.