fix: error custom edge case #379
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
gm @ccoVeille kindly review :) |
EwenQuim
requested changes
Jan 31, 2025
Comment on lines
+453
to
+461
| // Add middleware to strip trailing slash from requests | ||
| stripSlashMiddleware := func(next http.Handler) http.Handler { | ||
| return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | ||
| if len(r.URL.Path) > 1 { | ||
| r.URL.Path = strings.TrimRight(r.URL.Path, "/") | ||
| } | ||
| next.ServeHTTP(w, r) | ||
| }) | ||
| } |
There was a problem hiding this comment.
Please do not re-define this middleware each time the option is called. Place the middleware elsewhere :) Also, I think the middleware should be placed in Server.globalMiddlewares, see the difference in the docs.
EwenQuim
reviewed
Jan 31, 2025
Comment on lines
+453
to
+466
| // WithStripTrailingSlash enables stripping of trailing slashes from routes and requests | ||
| // Default is false. | ||
| // | ||
| // Example: | ||
| // | ||
| // app := fuego.NewServer( | ||
| // fuego.WithStripTrailingSlash(), | ||
| // ) | ||
| func WithStripTrailingSlash() func(*Server) { | ||
| return func(s *Server) { | ||
| // Add OptionStripTrailingSlash to the default route options | ||
| s.routeOptions = append(s.routeOptions, OptionStripTrailingSlash()) | ||
| } | ||
| } |
There was a problem hiding this comment.
Very good! With one Server Option, they will be able to have this feature :)
I think it should look like this:
s.routeOptions = append(s.routeOptions, OptionStripTrailingSlash())
s.globalMiddlewares = append(s.globalMiddlewares, stripTrailingSlashesMiddleware)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #322