Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add framework-agnostic mock context for testing #351
feat: add framework-agnostic mock context for testing #351
Changes from 1 commit
dc235ba
82afb5a
94d151c
6693115
6ab9051
50d594c
13dda83
3cea539
f051446
e3237c3
110137e
4792732
20732df
c2f039b
488feb9
08e3251
d8c2637
5383101
bc99b13
50e87a7
ccfa704
8357ed8
be830f5
f2ad6cc
97f21ef
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 401 in README.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not using a setter and not an exported attribute name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I use a setter method instead of an exported field to maintain encapsulation and consistency with real implementations. This allows to add validation or logging in the future without breaking user code and ensures tests reflect how the code will behave in production.
Check failure on line 105 in mock_context.go
Check failure on line 5 in mock_context_test.go