chore: set service name explicitly

go-faster · Jan 31, 2025 · 6008da3 · 6008da3
1 parent f91f78d
commit 6008da3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 28 deletions.
diff --git a/internal/cmd/client.go b/internal/cmd/client.go
@@ -11,8 +11,6 @@ import (
 	"github.com/go-faster/sdk/zctx"
 	"github.com/spf13/cobra"
 	"go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp"
-	"go.opentelemetry.io/otel/attribute"
-	"go.opentelemetry.io/otel/sdk/resource"
 	"go.uber.org/zap"
 
 	"github.com/go-faster/simon/internal/app"
@@ -75,18 +73,7 @@ func cmdClient() *cobra.Command {
 					}
 				}
 			},
-				sdka.WithResource(func(ctx context.Context) (*resource.Resource, error) {
-					return resource.New(ctx,
-						resource.WithOS(),
-						resource.WithFromEnv(),
-						resource.WithTelemetrySDK(),
-						resource.WithHost(),
-						resource.WithProcess(),
-						resource.WithAttributes(
-							attribute.String("service.name", "simon.client"),
-						),
-					)
-				}),
+				sdka.WithServiceName("simon.client"),
 			)
 		},
 	}

diff --git a/internal/cmd/server.go b/internal/cmd/server.go
@@ -14,8 +14,6 @@ import (
 	"github.com/rs/cors"
 	"github.com/spf13/cobra"
 	"go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp"
-	"go.opentelemetry.io/otel/attribute"
-	"go.opentelemetry.io/otel/sdk/resource"
 	"go.uber.org/zap"
 	"golang.org/x/sync/errgroup"
 
@@ -108,18 +106,7 @@ func cmdServer() *cobra.Command {
 				})
 				return g.Wait()
 			},
-				sdka.WithResource(func(ctx context.Context) (*resource.Resource, error) {
-					return resource.New(ctx,
-						resource.WithOS(),
-						resource.WithFromEnv(),
-						resource.WithTelemetrySDK(),
-						resource.WithHost(),
-						resource.WithProcess(),
-						resource.WithAttributes(
-							attribute.String("service.name", "simon.server"),
-						),
-					)
-				}),
+				sdka.WithServiceName("simon.server"),
 			)
 		},
 	}