Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go: update to version 1.18 #33

Merged
merged 1 commit into from
May 15, 2023
Merged

Conversation

KarthikNayak
Copy link
Contributor

Go only supports -2 major versions. Currently we're on Go 1.20, so the last supported version is 1.18.

Let's update the library from Go 1.17 to Go 1.18

Go only supports -2 major versions. Currently we're on Go 1.20, so the
last supported version is 1.18.

Let's update the library from Go 1.17 to Go 1.18
@KarthikNayak
Copy link
Contributor Author

KarthikNayak commented May 10, 2023

@bzz could you have a look at this? Also seems like a release is due, maybe after this?

CC @kuba-- @mcuadros

@KarthikNayak
Copy link
Contributor Author

@bzz could you have a look at this? Also seems like a release is due, maybe after this?

CC @kuba-- @mcuadros

@kuba-- could you please help merge this and create a new release version?

@kuba--
Copy link
Member

kuba-- commented May 15, 2023

@bzz could you have a look at this? Also seems like a release is due, maybe after this?
CC @kuba-- @mcuadros

@kuba-- could you please help merge this and create a new release version?

I can merge it, because I do not see any risk in the PR, but I think the right person to tag a new release is @bzz

@kuba-- kuba-- merged commit e0d6f01 into go-enry:master May 15, 2023
@kuba--
Copy link
Member

kuba-- commented May 15, 2023

@KarthikNayak
Copy link
Contributor Author

Thank you @kuba-- , waiting on this release since we also want to use the changes from bae4e82.

Any idea when this will draft will be released? (The draft is private btw, I cannot access it).

@KarthikNayak KarthikNayak deleted the go-update branch May 17, 2023 13:25
@kuba--
Copy link
Member

kuba-- commented May 19, 2023

I've published as a _ Pre-release_, so should be available.
PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants