Skip to content
This repository has been archived by the owner on Feb 16, 2022. It is now read-only.

Make Organization API coherent with the SDK #246

Merged
merged 2 commits into from
Oct 23, 2021
Merged

Conversation

alexkappa
Copy link
Contributor

Proposed Changes

Make OrganizationManager more coherent by following certain conventions used throughout the SDK. More specifically:

  • management.OrganizationBranding: LogoUrl field renamed to LogoURL
  • management.OrganizationBranding: Colors type changed to map[string]interface{}
  • management.OrganizationInvitation: InvitationUrl field renamed to InvitationURL
  • management.OrganizationManager: Create method doesn't clear ID
  • management.OrganizationManager: Update method accepts an id parameter as first argument and doesn't clear ID, Name
  • management.OrganizationManager: UpdateConnection method accepts an connectionID parameter and doesn't clear ConnectionID, Connection
  • management.OrganizationManager: CreateInvitation method accepts an id parameter as first argument and doesn't clear ConnectionID

Acceptance Test Output

$ go test ./... -run TestOrganization                                                                                                                       [16:30:13]
ok      gopkg.in/auth0.v5       (cached) [no tests to run]
ok      gopkg.in/auth0.v5/internal/client       (cached) [no tests to run]
ok      gopkg.in/auth0.v5/internal/tag  (cached) [no tests to run]
ok      gopkg.in/auth0.v5/internal/testing/expect       (cached) [no tests to run]
ok      gopkg.in/auth0.v5/management    3.871s

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

@alexkappa alexkappa merged commit 210d01d into master Oct 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant