This repository has been archived by the owner on Feb 16, 2022. It is now read-only.
Make Organization API coherent with the SDK #246
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Make
OrganizationManager
more coherent by following certain conventions used throughout the SDK. More specifically:management.OrganizationBranding
:LogoUrl
field renamed toLogoURL
management.OrganizationBranding
:Colors
type changed tomap[string]interface{}
management.OrganizationInvitation
:InvitationUrl
field renamed toInvitationURL
management.OrganizationManager
:Create
method doesn't clear IDmanagement.OrganizationManager
:Update
method accepts anid
parameter as first argument and doesn't clearID
,Name
management.OrganizationManager
:UpdateConnection
method accepts anconnectionID
parameter and doesn't clearConnectionID
,Connection
management.OrganizationManager
:CreateInvitation
method accepts anid
parameter as first argument and doesn't clearConnectionID
Acceptance Test Output
Community Note