Skip to content
This repository has been archived by the owner on Feb 16, 2022. It is now read-only.

Support google-apps connection strategy #212

Merged
merged 1 commit into from
May 6, 2021
Merged

Support google-apps connection strategy #212

merged 1 commit into from
May 6, 2021

Conversation

nicholaswold
Copy link

I'm still wrapping my head around the repo (and golang in general) so thanks for your patience with any simple mistakes 🙏

Proposed Changes

  • Adds a new connection strategy for google-apps connections

Acceptance Test Output

I expected the error below to go away after setting up a test tenant and putting the domain in .env. Unsure what mistake I'm making here.

$ go test ./... -v -run TestUser

testing: warning: no tests to run
PASS
ok      gopkg.in/auth0.v5       (cached) [no tests to run]
testing: warning: no tests to run
PASS
ok      gopkg.in/auth0.v5/internal/client       (cached) [no tests to run]
testing: warning: no tests to run
PASS
ok      gopkg.in/auth0.v5/internal/tag  (cached) [no tests to run]
testing: warning: no tests to run
PASS
ok      gopkg.in/auth0.v5/internal/testing/expect       (cached) [no tests to run]
=== RUN   TestUser
    user_test.go:47: Post "https://api/v2/roles": Post "https:///oauth/token": http: no Host in request URL
--- FAIL: TestUser (0.00s)
=== RUN   TestUserIdentity
=== RUN   TestUserIdentity/MarshalJSON
=== RUN   TestUserIdentity/UnmarshalJSON
--- PASS: TestUserIdentity (0.00s)
    --- PASS: TestUserIdentity/MarshalJSON (0.00s)
    --- PASS: TestUserIdentity/UnmarshalJSON (0.00s)
FAIL
FAIL    gopkg.in/auth0.v5/management    0.018s
FAIL

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

@yvovandoorn
Copy link
Contributor

@nicholaswold excellent. This looks great.

one more thing is to regenerate the files by running go generate ./.... Commit the updated management.go file and the PR will be complete.

Thanks!

@nicholaswold
Copy link
Author

Done!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants