Skip to content
This repository has been archived by the owner on Feb 16, 2022. It is now read-only.

Add support for Auth0 SAML connection entityId option #209

Conversation

twistedstream
Copy link
Contributor

Proposed Changes

  • Add EntityID field to the ConnectionOptionsSAML structure which maps to the options.entityId field of the Auth0 Connection object for SAML connections.

Acceptance Test Output

$ go test ./... -v -run TestConnection

...

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

@yvovandoorn
Copy link
Contributor

Confirmed its passing tests:

go test ./... -run TestConnection                  ✔ │ 21:45:56  
ok  	gopkg.in/auth0.v5	0.068s [no tests to run]
ok  	gopkg.in/auth0.v5/internal/client	0.042s [no tests to run]
ok  	gopkg.in/auth0.v5/internal/tag	0.077s [no tests to run]
ok  	gopkg.in/auth0.v5/internal/testing/expect	0.072s [no tests to run]
ok  	gopkg.in/auth0.v5/management	16.766s

@yvovandoorn
Copy link
Contributor

LGTM, merging.

@yvovandoorn yvovandoorn merged commit 03dc374 into go-auth0:master Apr 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants