Skip to content
This repository has been archived by the owner on Feb 16, 2022. It is now read-only.

Have Grant List also use applyListDefaults. #205

Merged
merged 3 commits into from
Mar 26, 2021

Conversation

yvovandoorn
Copy link
Contributor

Proposed Changes

  • Have Grant List also use applyListDefaults.

Fixes #168

Acceptance Test Output

go test ./... -v -run TestGrant                                     
=== RUN   TestGrant
=== RUN   TestGrant/List
    grant_test.go:15: []
--- PASS: TestGrant (0.47s)
    --- PASS: TestGrant/List (0.47s)
PASS
ok  	gopkg.in/auth0.v5/management	(cached)

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

@yvovandoorn
Copy link
Contributor Author

@paddycarey or @jbauth0 a solid double check would be good here. I think this is the behavior we want out of user_grants.

@yvovandoorn yvovandoorn changed the title Bug apply list defaultson grant/1 Have Grant List also use applyListDefaults. Mar 23, 2021
@yvovandoorn
Copy link
Contributor Author

@alexkappa addressed your comments. Thanks for pointing me to GrantList.

Should be good to go now!

Copy link
Contributor

@alexkappa alexkappa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you @yvovandoorn

@yvovandoorn yvovandoorn merged commit 28be2d8 into master Mar 26, 2021
@yvovandoorn yvovandoorn deleted the bug-applyListDefaultsonGrant/1 branch March 26, 2021 20:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enforcement of paginated API responses from the auth0 management v2 API
2 participants