Skip to content
This repository has been archived by the owner on Feb 16, 2022. It is now read-only.

fix: add missing AzureAD connection option #198

Merged
merged 2 commits into from
Feb 23, 2021

Conversation

ollystephens
Copy link
Contributor

@ollystephens ollystephens commented Feb 16, 2021

The AzureAD connection type has an advanced option that is currently missing from this API.
It lets you choose whether or not to set the email_verified to true when a new user connects.
Due to the complexities of the azure connections, there are ramifications to setting this which are explained in the auth0 docs.

Adding the extra optional attribute in here so that it can be subsequently added to the terraform provider.

Proposed Changes

  • add optional TrustEmailVerified option to the AzureAD connection object

Acceptance Test Output

Unfortunately there are currently no AzureAD specific tests, so nothing to modify.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

@alexkappa alexkappa merged commit 9c75c15 into go-auth0:master Feb 23, 2021
@alexkappa
Copy link
Contributor

Merging. Thanks @ollystephens !

@mafodev
Copy link

mafodev commented Mar 10, 2021

@alexkappa I would like to integrate this into the terraform-provider-auth0. When do you plan on releasing a version with this change or rather is there anything I can do to support a release in the near future?

@ollystephens
Copy link
Contributor Author

Hi @mafodev. I have the corresponding changes for terraform-provider-auth0 queued up and ready. Was also just waiting on a release of this library from @alexkappa before pushing the PR.

@ollystephens ollystephens deleted the add-missing-azuread-options branch March 10, 2021 15:08
@mafodev
Copy link

mafodev commented Mar 10, 2021

Hey @ollystephens. That's awesome! Since I don't have that much knowledge with golang I am glad that your are also working on the terraform provider. In that case I am looking forward to your PR :-) Thanks for letting me know.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants