-
-
Notifications
You must be signed in to change notification settings - Fork 128
Conversation
Sorry, I'm not sure how to run the Test action 😅 |
62115fa
to
acdfcf1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jmaeso, thank you for taking the time to put this together!
The code looks pretty good. I made a couple of suggestions on aligning it more with the conventions used throughout the codebase.
Once ready you can ping me again so I can test/merge.
Cheers,
Alex
management/user_test.go
Outdated
@@ -260,6 +260,37 @@ func TestUser(t *testing.T) { | |||
} | |||
t.Logf("%v\n", us) | |||
}) | |||
|
|||
t.Run("Link", func(t *testing.T) { | |||
ulAlice, err := m.User.Search(Query(`email:"alice@example.com"`)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can also create a couple users, that better represent linking between two identities. We can make a better example of linking Batman to Bruce Wayne or Heisenberg to Walter White 😄
Just remember to clean up once done
t.Cleanup(func() {
m.User.Delete(walter.GetID())
m.User.Delete(heisenberg.GetID())
})
Good comments @alexkappa , they make sense, I'll address them ASAP. |
dd1a2c1
to
845010a
Compare
845010a
to
74396f6
Compare
ping @alexkappa |
Thanks @jmaeso, sorry about the request/response limitations you are experiencing here. It's quite uncommon but happens from time to time the payload of the request being different than that of the response. For now I would suggest calling the contents of |
8d53dff
to
1714804
Compare
Comments applied @alexkappa |
Nicely done @jmaeso! I've tested locally and merged it in. Will publish a release shortly. |
Opening PR since looks to be the only way of running tests. Pending to verify if the feature works