Skip to content
This repository has been archived by the owner on Feb 16, 2022. It is now read-only.

fixed wrong property names for tokenURL and authorizationURL #147

Merged
merged 4 commits into from
Nov 1, 2020

Conversation

mcalster
Copy link
Contributor

@mcalster mcalster commented Sep 28, 2020

Signed-off-by: Kim Alster Glimberg <kagli@kims-mbp.lan>
@mcalster
Copy link
Contributor Author

@alexkappa This is ready to go. I've introduced two new attributes following the API naming.
Please review.

Kim Alster Glimberg added 2 commits September 29, 2020 16:29
@alexkappa
Copy link
Contributor

Hi @mcalster is this documented somewhere? Perhaps we should include these fields in our test case so we catch this earlier.

@mcalster
Copy link
Contributor Author

mcalster commented Oct 2, 2020

@alexkappa

is this documented somewhere?

I was only able to find it by creating the oauth2 connection, and then extract it via the API. Here is an example response:

{
    "id": "con_12345",
    "options": {
        "scope": "openid",
        "scripts": {
            "fetchUserProfile": "async function retrieveUserProfile(accessToken, context, callback) { callback(null, null);\n}"
        },
        "**tokenURL**": "https://example.com/oauth2/token",
        "client_id": "test-client",
        "client_secret": "SoooSecret",
        "**authorizationURL**": "https:/example.com/oauth2/authorize"
    },
    "strategy": "oauth2",
    "name": "oauth2-test",
    "is_domain_connection": false,
    "realms": [
        "oauth2-test"
    ],
    "enabled_clients": []
},

I haven't been able to find it in the API documentation.

Perhaps we should include these fields in our test case so we catch this earlier.

It's is hard to verify beforehand? Since all four properties are accepted as valid parameters for an oauth2 connection.

I've added the parameters in the test for clarity.

Signed-off-by: Kim Alster <abkias@almbrand.dk>
Copy link
Contributor Author

@mcalster mcalster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcalster mcalster requested a review from alexkappa October 12, 2020 19:14
@mcalster
Copy link
Contributor Author

@alexkappa anything I can do to push this forward? I know this is a spare time project, so if I can help in anyway :-)

@alexkappa alexkappa merged commit 8bc5f52 into go-auth0:master Nov 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in Oauth2 Connection Support
3 participants