-
-
Notifications
You must be signed in to change notification settings - Fork 128
fixed wrong property names for tokenURL and authorizationURL #147
Conversation
Signed-off-by: Kim Alster Glimberg <kagli@kims-mbp.lan>
@alexkappa This is ready to go. I've introduced two new attributes following the API naming. |
Signed-off-by: Kim Alster Glimberg <kagli@kims-mbp.lan>
…r/auth0 into bug/wrong-property-names
Hi @mcalster is this documented somewhere? Perhaps we should include these fields in our test case so we catch this earlier. |
I was only able to find it by creating the oauth2 connection, and then extract it via the API. Here is an example response:
I haven't been able to find it in the API documentation.
It's is hard to verify beforehand? Since all four properties are accepted as valid parameters for an oauth2 connection. I've added the parameters in the test for clarity. |
Signed-off-by: Kim Alster <abkias@almbrand.dk>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@alexkappa anything I can do to push this forward? I know this is a spare time project, so if I can help in anyway :-) |
Fixes #146
Blocks: alexkappa/terraform-provider-auth0#272