return EOF when reading first byte of an ASN.1 packet #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove UnexpectedEOF from readByte() * explicitly turn EOF to UnexpectedEOF at each call site
"empty buffer" now returns EOF fixes go-asn1-ber#34
|
Hello Any chance to get this pull request reviewed ? |
|
Hello again Any news on the possibility to review this Pull Request ? I think the scope of the modifications is pretty tight, and the unit tests should cover the cases we want to check |
|
My apologies - this PR looks very good; thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proposed evolution for #34