Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix README #33

Merged
merged 2 commits into from
Jan 14, 2025
Merged

fix README #33

merged 2 commits into from
Jan 14, 2025

Conversation

zirain
Copy link
Contributor

@zirain zirain commented Jan 13, 2025

IIUC, this's wrong after v0.4.

Signed-off-by: zirain <zirain2009@gmail.com>
@jentfoo
Copy link
Member

jentfoo commented Jan 13, 2025

Thank you for the contribution @zirain! You are correct that the README was not updated here for v0.4. However since this is now the default, I think we should go ahead and remove this line from the README.

Would you like to update your commit to just remove the line?

Signed-off-by: zirain <zirain2009@gmail.com>
@zirain
Copy link
Contributor Author

zirain commented Jan 13, 2025

Thank you for the contribution @zirain! You are correct that the README was not updated here for v0.4. However since this is now the default, I think we should go ahead and remove this line from the README.

Would you like to update your commit to just remove the line?

updated.

@jentfoo jentfoo merged commit b32302f into go-analyze:main Jan 14, 2025
@zirain zirain deleted the fix-readme branch January 14, 2025 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants