Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(pool): Extract JSON from pool api #500

Merged
merged 2 commits into from
Feb 5, 2025
Merged

refactor(pool): Extract JSON from pool api #500

merged 2 commits into from
Feb 5, 2025

Conversation

notJoon
Copy link
Member

@notJoon notJoon commented Feb 4, 2025 •
edited
Loading

Description

  • Extract JSON builder from pool API

related with #473

@notJoon notJoon added refactoring pool Pool contract related tasks labels Feb 4, 2025
@notJoon notJoon requested review from onlyhyde and r3v4s February 4, 2025 05:15
r3v4s
r3v4s approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@r3v4s r3v4s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor two questions.

@notJoon notJoon mentioned this pull request Feb 5, 2025
Draft
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 5, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@notJoon notJoon merged commit 73aa1c1 into main Feb 5, 2025
19 checks passed
@notJoon notJoon deleted the pool-json branch February 5, 2025 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onlyhyde onlyhyde onlyhyde approved these changes

@r3v4s r3v4s r3v4s approved these changes

Assignees
No one assigned
Labels
pool Pool contract related tasks refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@notJoon @onlyhyde @r3v4s