Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Use strconv in event when formatting values #476

Merged
merged 1 commit into from
Jan 21, 2025
Merged

chore: Use strconv in event when formatting values #476

merged 1 commit into from
Jan 21, 2025

Conversation

notJoon
Copy link
Member

@notJoon notJoon commented Jan 21, 2025 •
edited
Loading

closes #472

Note: While I could move the parseUint and parseInt functions to the common package, I added them to the utils file to prevent an increase in cycles due to package calls.

@notJoon notJoon requested review from onlyhyde and r3v4s January 21, 2025 03:20
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
42.8% Duplication on New Code

See analysis details on SonarQube Cloud

r3v4s
r3v4s approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@r3v4s r3v4s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@r3v4s
Copy link
Member

r3v4s commented Jan 21, 2025

What do you think about moving all conversion in to p/gnoswap/XXX ?

@notJoon
Copy link
Member Author

notJoon commented Jan 21, 2025

What do you think about moving all conversion in to p/gnoswap/XXX ?

@r3v4s I will consider it when dividing the packages later.

@notJoon notJoon merged commit b7f9fa5 into main Jan 21, 2025
1 of 2 checks passed
@notJoon notJoon deleted the emit-update branch January 21, 2025 05:39
moul pushed a commit that referenced this pull request Jan 21, 2025
@notJoon @moul
use strconv (#476)
77e683e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onlyhyde onlyhyde onlyhyde approved these changes

@r3v4s r3v4s r3v4s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using strconv Instead of ufmt When Emitting Events
3 participants
@notJoon @r3v4s @onlyhyde