Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specifying of multiple CLOSE_TIME_UP_TO_N_DAYS for replicator #92

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Allow specifying of multiple CLOSE_TIME_UP_TO_N_DAYS for replicator #92

merged 2 commits into from
Apr 19, 2024

Conversation

kongzii
Copy link
Contributor

@kongzii kongzii commented Apr 19, 2024 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • New Features
    • Enhanced the market replication feature to dynamically adjust closure times based on different days, allowing for more tailored market operations.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 19, 2024 •
edited
Loading

Warning

Rate Limit Exceeded

@kongzii has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 50 minutes and 17 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between 18f6693 and b6170e2.

Walkthrough

The recent update enhances the deploy.py script within the replicate_to_omen_agent module to dynamically handle market closure times across different days. This adjustment allows the system to adapt its replication process based on the specific market types and their respective closure schedules, offering a more tailored and efficient operation.

Changes

File Path Change Summary
.../replicate_to_omen_agent/deploy.py Enhanced to iterate over a list of days, adjusting market closure times and replicating from various market types accordingly.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Apr 19, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

prediction_market_agent/agents/replicate_to_omen_agent/deploy.py Outdated
@@ -16,7 +16,7 @@
omen_finalize_and_resolve_and_claim_back_all_markets_based_on_others_tx,
)
from prediction_market_agent_tooling.tools.utils import utcnow
from pydantic_settings import BaseSettings, SettingsConfigDict
from pydantic_settings import BaseSettings, SettingsConfigDict, mode
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the unused import mode.

- from pydantic_settings import BaseSettings, SettingsConfigDict, mode
+ from pydantic_settings import BaseSettings, SettingsConfigDict
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
from pydantic_settings import BaseSettings, SettingsConfigDict, mode
from pydantic_settings import BaseSettings, SettingsConfigDict

kongzii
kongzii commented Apr 19, 2024
View reviewed changes
prediction_market_agent/agents/replicate_to_omen_agent/deploy.py
@@ -26,7 +26,7 @@ class ReplicateSettings(BaseSettings):

N_TO_REPLICATE: int
INITIAL_FUNDS: str
CLOSE_TIME_UP_TO_N_DAYS: int
CLOSE_TIME_UP_TO_N_DAYS: list[int]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we can force to replicate markets that will close soon, but at the same time these that will close in a year or so

@kongzii kongzii merged commit e2b426a into main Apr 19, 2024
6 checks passed
@kongzii kongzii deleted the peter/multiple-close-times branch April 19, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@evangriffiths evangriffiths evangriffiths approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kongzii @evangriffiths