Coinflip agent deployment #64

kongzii · 2024-04-10T12:58:40Z

No description provided.

coderabbitai · 2024-04-10T12:58:51Z

Walkthrough

This set of updates introduces a new Docker setup and updates tooling for deploying non-predicting agents in prediction markets. Changes include Docker and script configurations for efficient builds and deployments, updates to version control ignores, and an enhancement in the project's dependency management.

Changes

File(s)	Change Summary
`.dockerignore`, `Dockerfile`	Introduced Docker configurations for optimized image building and size.
`.gitignore`	Updated to include `.env`, `.agents_workspace`, `.cache` and exclude `requirements.txt`, `.venv`.
`build.sh`	Added a script for building and pushing Docker images to a registry.
`pyproject.toml`	Updated dependency `prediction-market-agent-tooling` to version `^0.10.0`.
`.../coinflip_agent/coinflip_agent.py`, `deploy.py`	Added `DeployableCoinFlipAgent` class for deploying non-predicting agents in prediction markets.

Possibly related issues

Issue Refactor for nice deployment of non-predicting agents. prediction-market-agent-tooling#63: The changes in this PR seem to align with the objectives of making deployments of non-predicting agents more streamlined, as described in the issue. This is evident from the addition of DeployableCoinFlipAgent which is designed for such deployments.

Recent Review Details

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 45973f2 and fc07332.

Files selected for processing (1)

prediction_market_agent/run_agent.py (1 hunks)

Files skipped from review as they are similar to previous changes (1)

prediction_market_agent/run_agent.py

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 1

build.sh

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

evangriffiths · 2024-04-11T09:49:03Z

Dockerfile

+
+COPY prediction_market_agent ./prediction_market_agent
+
+ENV PYTHONPATH=/app


Do we need a CMD/ENTRYPOINT here or is that done in the Kubernetes config? I guess if we're building this in CI then we want to test running it too?

Good question, command is easily changeable and I put it into Terraform https://github.com/gnosis/gnosisai-infrastructure/pull/3/files#diff-fa25fb4ef6fa67ec2382f07d26b9039099ce7a314a7e98517370a8439a0d0365R42

But if I put it here, it's easier to change it without the need for updating Terraform 🤔 I'll give it a try!

I would also support @evangriffiths suggestion, the Entrypoint seems to me something that should be part of the image definition.

Yep works fine, updated 🙏

evangriffiths · 2024-04-11T12:34:24Z

prediction_market_agent/agents/coinflip_agent/coinflip_agent.py

+        return random.sample(markets, 1)
+
+    def answer_binary_market(self, market: AgentMarket) -> bool | None:
+        return random.choice([True, False])


Should we make it a convention to have:

prediction_market_agent/agents/<agent_name>/<agent_name>.py: core code

prediction_market_agent/agents/<agent_name>/deploy.py: subclassing DeployableAgent

?

I guess that would mean just renaming this file delploy.py

I see known_outcome_agent already uses (2), so I changed it to that one. Didn't notice it before, sorry!

coderabbitai

Actionable comments posted: 2

prediction_market_agent/agents/coinflip_agent/deploy.py

Coinflip agent deployment

e089da2

coderabbitai bot reviewed Apr 10, 2024

View reviewed changes

build.sh Show resolved Hide resolved

kongzii marked this pull request as draft April 10, 2024 13:25

kongzii and others added 6 commits April 10, 2024 16:13

update repo

0a301c5

fix

520a34a

Merge branch 'main' into peter/deployment

430dc7f

fix docker

202aade

Merge branch 'main' into peter/deployment

da074ee

Update build.sh

fdfd533

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

kongzii marked this pull request as ready for review April 11, 2024 09:21

kongzii added 2 commits April 11, 2024 11:23

lint

4b4cdd1

fixes

37c117e

evangriffiths reviewed Apr 11, 2024

View reviewed changes

kongzii added 2 commits April 11, 2024 13:07

update docker

abe8ecb

fix

a6ef95f

evangriffiths reviewed Apr 11, 2024

View reviewed changes

evangriffiths approved these changes Apr 11, 2024

View reviewed changes

rename

45973f2

coderabbitai bot reviewed Apr 11, 2024

View reviewed changes

prediction_market_agent/agents/coinflip_agent/deploy.py Show resolved Hide resolved

prediction_market_agent/agents/coinflip_agent/deploy.py Show resolved Hide resolved

lint

fc07332

kongzii merged commit 0b1b213 into main Apr 11, 2024
6 checks passed

kongzii deleted the peter/deployment branch April 11, 2024 12:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Coinflip agent deployment #64

Coinflip agent deployment #64

kongzii commented Apr 10, 2024

coderabbitai bot commented Apr 10, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

evangriffiths Apr 11, 2024

kongzii Apr 11, 2024

gabrielfior Apr 11, 2024

kongzii Apr 11, 2024

evangriffiths Apr 11, 2024

kongzii Apr 11, 2024

coderabbitai bot left a comment


		COPY prediction_market_agent ./prediction_market_agent

		ENV PYTHONPATH=/app

Coinflip agent deployment #64

Coinflip agent deployment #64

Conversation

kongzii commented Apr 10, 2024

coderabbitai bot commented Apr 10, 2024 • edited Loading

Walkthrough

Changes

Possibly related issues

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

evangriffiths Apr 11, 2024

Choose a reason for hiding this comment

kongzii Apr 11, 2024

Choose a reason for hiding this comment

gabrielfior Apr 11, 2024

Choose a reason for hiding this comment

kongzii Apr 11, 2024

Choose a reason for hiding this comment

evangriffiths Apr 11, 2024

Choose a reason for hiding this comment

kongzii Apr 11, 2024

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot commented Apr 10, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)