Bump PMAT version to 0.9.3, simplify `calculate_bet_amount` for KnownOutcomeAgent #51

evangriffiths · 2024-04-05T15:31:46Z

Summary by CodeRabbit

Refactor
- Simplified the bet amount calculation logic for OmenAgentMarket.

coderabbitai · 2024-04-05T15:31:51Z

Walkthrough

The recent update to the prediction_market_agent module involves refining the betting logic for the OmenAgentMarket. This includes simplifying the BetAmount calculation method and ensuring the agent only supports predictions on Omen markets. Additionally, a typo in a print statement was corrected for improved clarity.

Changes

File	Change Summary
`.../known_outcome_agent/deploy.py`	Removed `Currency` import; Simplified `BetAmount` calculation and added support check for Omen markets.
`.../known_outcome_agent/known_outcome_agent.py`	Corrected a typo in a print statement: "Searchig" changed to "Searching."

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

Review Status

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 82c8142 and 3006a31.

Files ignored due to path filters (1)

pyproject.toml is excluded by !**/*.toml

Files selected for processing (1)

prediction_market_agent/agents/known_outcome_agent/deploy.py (2 hunks)

Additional comments not posted (1)

prediction_market_agent/agents/known_outcome_agent/deploy.py (1)

85-85: Consider adding a comment explaining the rationale behind using a fixed bet amount and relying on market.currency directly in the calculate_bet_amount method. This will help maintain clarity and understanding for future maintenance or enhancements.

kongzii · 2024-04-05T16:40:37Z

prediction_market_agent/agents/known_outcome_agent/deploy.py

-                ),
-                currency=Currency.xDai,
-            )
+            return BetAmount(amount=(Decimal(1.0)), currency=market.currency)


I know we now filtering for markets with liquidity, but people can still create markets with for example, $0.01 in liquidity and then it doesn't make much sense to me to bet more than the minimal bet. wdyt?

Good point. In that case, I think it makes sense to filter the market at the pick_markets stage, so as not to waste openai API credits. I've made that change above

Don't you want to keep them for benchmark purposes?

If not, okay by me, just that

elif market.get_liquidity_in_xdai() > 5: print( f"Skipping market {market.id=} {market.question=}, because it has insufficient liquidity." )

Should it be with the opposite sign, probably?

Don't you want to keep them for benchmark purposes?

I'm not too concerned about that, more about trying to get the markets that should be p_yes/no==0.95 to that point

coderabbitai

Actionable comments posted: 0

Review Status

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 3006a31 and 38bbeba.

Files ignored due to path filters (1)

poetry.lock is excluded by !**/*.lock

Files selected for processing (2)

prediction_market_agent/agents/known_outcome_agent/deploy.py (4 hunks)
prediction_market_agent/agents/known_outcome_agent/known_outcome_agent.py (1 hunks)

Files skipped from review due to trivial changes (1)

prediction_market_agent/agents/known_outcome_agent/known_outcome_agent.py

Files skipped from review as they are similar to previous changes (1)

prediction_market_agent/agents/known_outcome_agent/deploy.py

kongzii · 2024-04-08T14:55:31Z

prediction_market_agent/agents/known_outcome_agent/deploy.py

@@ -28,14 +27,19 @@ def market_is_saturated(market: AgentMarket) -> bool:


 class DeployableKnownOutcomeAgent(DeployableAgent):
-    model = "gpt-4-1106-preview"
+    model = "gpt-4-turbo-preview"


I just noticed this as well, this can point to a different model in future without notice, is that desirable?

Hmm good question. Maybe in general not, but I reckon for this case it's good - my reasoning being that otherwise over time the agent will get less and less 'up to date with current events' which I would assume is bad for making future predictions.

coderabbitai

Actionable comments posted: 0

Review Status

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 38bbeba and 513de02.

Files selected for processing (1)

prediction_market_agent/agents/known_outcome_agent/deploy.py (4 hunks)

Files skipped from review as they are similar to previous changes (1)

prediction_market_agent/agents/known_outcome_agent/deploy.py

Bump PMAT version to 0.9.3, simplify

3006a31

evangriffiths requested a review from kongzii April 5, 2024 15:31

coderabbitai bot reviewed Apr 5, 2024

View reviewed changes

Update poetry.lock

bc864ec

evangriffiths requested a review from gabrielfior April 5, 2024 15:59

kongzii reviewed Apr 5, 2024

View reviewed changes

Skip markets with small liquidity

38bbeba

evangriffiths requested a review from kongzii April 8, 2024 14:46

coderabbitai bot reviewed Apr 8, 2024

View reviewed changes

Oops

513de02

kongzii approved these changes Apr 8, 2024

View reviewed changes

kongzii reviewed Apr 8, 2024

View reviewed changes

coderabbitai bot reviewed Apr 8, 2024

View reviewed changes

evangriffiths merged commit ee7a7a6 into main Apr 8, 2024
6 checks passed

evangriffiths deleted the evan/bump-pmat-version-093 branch April 8, 2024 15:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump PMAT version to 0.9.3, simplify `calculate_bet_amount` for KnownOutcomeAgent #51

Bump PMAT version to 0.9.3, simplify `calculate_bet_amount` for KnownOutcomeAgent #51

evangriffiths commented Apr 5, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 5, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

kongzii Apr 5, 2024

evangriffiths Apr 8, 2024

kongzii Apr 8, 2024

evangriffiths Apr 8, 2024

evangriffiths Apr 8, 2024

coderabbitai bot left a comment

kongzii Apr 8, 2024

kongzii Apr 8, 2024

evangriffiths Apr 8, 2024

coderabbitai bot left a comment

Bump PMAT version to 0.9.3, simplify calculate_bet_amount for KnownOutcomeAgent #51

Bump PMAT version to 0.9.3, simplify calculate_bet_amount for KnownOutcomeAgent #51

Conversation

evangriffiths commented Apr 5, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot commented Apr 5, 2024 • edited Loading

Walkthrough

Changes

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

Bump PMAT version to 0.9.3, simplify `calculate_bet_amount` for KnownOutcomeAgent #51

Bump PMAT version to 0.9.3, simplify `calculate_bet_amount` for KnownOutcomeAgent #51

evangriffiths commented Apr 5, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 5, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)