Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JS->TS] Migrate ensure_owl_liquidity.js #820

Merged
merged 4 commits into from
May 30, 2020
Merged

[JS->TS] Migrate ensure_owl_liquidity.js #820

merged 4 commits into from
May 30, 2020

Conversation

bh2smith
Copy link
Contributor

@bh2smith bh2smith commented May 29, 2020 •
edited
Loading

Standard switch over, included a few additional logs (especially one noting that order retrieval might take a while). Partial fulfillment of #330

Test Plan

Run

yarn build
npx truffle exec build/common/scripts/ensure_owl_liquidity.js --network rinkeby
2020-05-29 11:28:35,033 INFO [scripts.owl_liquidity] Using account 0x627306090abaB3A6e1400e9345bC60c78a8BEf57
2020-05-29 11:28:37,568 INFO [scripts.owl_liquidity] Retrieving orders from exchange. This may take a while...

Wait a while...

2020-05-29 11:38:06,744 INFO [scripts.owl_liquidity] Checking liquidity for token 0xc778417E063141139Fce010982780140Aa0cD5Ab
2020-05-29 11:38:06,745 INFO [scripts.owl_liquidity]     Liquidity for 0xc778417E063141139Fce010982780140Aa0cD5Ab is given or has been provided in the past
2020-05-29 11:38:07,491 INFO [scripts.owl_liquidity] Checking liquidity for token 0xa9881E6459CA05d7D7C95374463928369cD7a90C
2020-05-29 11:38:07,492 INFO [scripts.owl_liquidity]     Liquidity for 0xa9881E6459CA05d7D7C95374463928369cD7a90C is given or has been provided in the past
...
2020-05-29 11:38:13,959 INFO [scripts.owl_liquidity] Checking liquidity for token 0xD0DC005d31C2979CC0d38718e23c82D1A50004C0
2020-05-29 11:38:14,866 INFO [scripts.owl_liquidity] Checking liquidity for token 0xAe38b81459d74A8C16eAa968c792207603D84480
2020-05-29 11:38:15,605 INFO [scripts.owl_liquidity] Checking liquidity for token 0x0647b2C7a2a818276154b0fC79557F512B165bc1
2020-05-29 11:38:15,606 INFO [scripts.owl_liquidity]     Liquidity for 0x0647b2C7a2a818276154b0fC79557F512B165bc1 is given or has been provided in the past
2020-05-29 11:38:16,578 INFO [scripts.owl_liquidity] Checking liquidity for token 0x1b642a124CDFa1E5835276A6ddAA6CFC4B35d52c
2020-05-29 11:38:16,579 INFO [scripts.owl_liquidity]     Liquidity for 0x1b642a124CDFa1E5835276A6ddAA6CFC4B35d52c is given or has been provided in the past
2020-05-29 11:38:18,077 INFO [scripts.owl_liquidity] Placing orders for 10,11
2020-05-29 11:38:26,998 INFO [scripts.owl_liquidity] Placed fee token liquidity orders for tokens:

@bh2smith bh2smith requested a review from a team May 29, 2020 09:32
fleupold
fleupold approved these changes May 29, 2020
View reviewed changes
Copy link
Contributor

@fleupold fleupold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@bh2smith bh2smith merged commit 3633d36 into master May 30, 2020
@bh2smith bh2smith deleted the 330/migrate_ensure_owl_liquidity branch May 30, 2020 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fleupold fleupold fleupold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bh2smith @fleupold