[JS->TS] Migrate invokeViewFunction.js #815
Conversation
c747b04 to
e0d5563
Compare
scripts/invoke_view_function.ts
Outdated
| } | ||
| const [functionName, ...arg] = args; | ||
| const exchange = await getBatchExchange(artifacts); | ||
| const info = await (exchange as any)[functionName].call(...arg); |
There was a problem hiding this comment.
Sadly... This was unsuccessful.
There was a problem hiding this comment.
info is of type BN which doesn't seem to print well with log.info (it works with console.log)
|
If nobody is opposed, I'd like to take the opportunity to remove this function that is not used anywhere. However, in the essence of making everything TS compatible, I would endure and see this through if desired. |
scripts/invoke_view_function.ts
Outdated
| } | ||
| const [functionName, ...arg] = args; | ||
| const exchange = await getBatchExchange(artifacts); | ||
| const info = await (exchange as any)[functionName].call(...arg); |
There was a problem hiding this comment.
info is of type BN which doesn't seem to print well with log.info (it works with console.log)
| // one would usually grep for the results of this execution. Thus, | ||
| // the raw output is printed rather than include irrelevant log details. | ||
| // eslint-disable-next-line no-console | ||
| console.log(info); |
There was a problem hiding this comment.
Curious, is there a reason you didn't use info.toString() ?
There was a problem hiding this comment.
Actually I think I meant to although this printed fine with getCurrentBatchId
Partially fulfills #330. Unfortunately, I have not been able to get expected values returned from this script just yet. This snippet is the closest example in the current code base
dex-contracts/src/onchain_reading.ts
Lines 89 to 91 in 7cabfe1
I can verify that logging
contract.methodsdoes indeed contain the methods as strings.Test Plan
npx truffle exec build/common/scripts/invoke_view_function.js --network mainnet getCurrentBatchIdCurrently getting back
undefined.