feat: add p/demo/bf (brainfuck vm) #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
|
Just gotta make it run https://github.com/matslina/awib to see Gno compile BF to i386 binaries :) |
|
Next step: EVM. |
This was referenced Jun 16, 2023
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
thehowl
approved these changes
Jul 5, 2023
Comment on lines
+37
to
+48
| // Jump forward past the matching ']' if the byte at the memory pointer is zero | ||
| if memory[pointer] == 0 { | ||
| braceCount := 1 | ||
| for braceCount > 0 { | ||
| i++ | ||
| if code[i] == '[' { | ||
| braceCount++ | ||
| } else if code[i] == ']' { | ||
| braceCount-- | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
we could make this use a stack of open brackets, popped each time we go out of a loop, probably better for memory/efficiency... but if you don't want to do it it's fine :)
There was a problem hiding this comment.
let's keep this for when we'll have better benchmarking tools as a good example of runtime and gas optimization.
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Manfred Touron 94029+moul@users.noreply.github.com
Description
Please provide a detailed description of the changes made in this pull request.
Contributors Checklist
BREAKING CHANGE: xxxmessage was included in the descriptionMaintainers Checklist
CONTRIBUTING.mdBREAKING CHANGE:in the body)