refactor(rpc): handlers.go - makeJSONRPCHandler() control flow refactor

[masonmcbride]

I am proposing a simpler way to write the makeJSONRPCHandler function. There was a recent bug due to this function that turned lists of requests with a single item to a object that is a response--but not a list of responses. With this refactor, this function would be more resilient to bugs because of its simplified control flow: it first tries to unmarshal as an slice of requests, and returns an array of responses if successful. It then tries to unmarshal it into a single request, and returns a single response if successful. This refactor also abstracts the logic that process the requests to see if they actually need to be sent. All of that logic is now in the processRequest function, and improves on the previous implementation because now makeJSONRPCHandle is much easier to read and understand. If both unmarshals fail, the function returns an error "error unmarshalling request," same as before. Please let me know what you think of the refactor. Thanks.

[Gno2D2]

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):

• IGNORE the bot requirements for this PR (force green CI check)

Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:

1. Fix any issues flagged by automated checks.
2. Follow the Contributor Checklist to ensure your PR is ready for review.
   • Add new tests, or document why they are unnecessary.
   • Provide clear examples/screenshots, if necessary.
   • Update documentation, if required.
   • Ensure no breaking changes, or include BREAKING CHANGE notes.
   • Link related issues/PRs, where applicable.

☑️ Reviewer Actions:

1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.

📚 Resources:

• Report a bug with the bot.
• View the bot’s configuration file.

Debug

Automated Checks

Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: masonmcbride/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks

**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

• Any user with comment edit permission

[codecov]

Codecov Report

Attention: Patch coverage is 85.71429% with 7 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
tm2/pkg/bft/rpc/lib/server/handlers.go	85.71%	5 Missing and 2 partials ⚠️

📢 Thoughts on this report? Let us know!

[aeddi]

Looks good 👍 your refactor makes this function more readable