fix(gno.land): limit gas in simulate and query

[thehowl]

fixes #3612
fixes #3563

[Gno2D2]

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):

• IGNORE the bot requirements for this PR (force green CI check)

Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:

1. Fix any issues flagged by automated checks.
2. Follow the Contributor Checklist to ensure your PR is ready for review.
   • Add new tests, or document why they are unnecessary.
   • Provide clear examples/screenshots, if necessary.
   • Update documentation, if required.
   • Ensure no breaking changes, or include BREAKING CHANGE notes.
   • Link related issues/PRs, where applicable.

☑️ Reviewer Actions:

1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.

📚 Resources:

• Report a bug with the bot.
• View the bot’s configuration file.

Debug

Automated Checks

Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: thehowl/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks

**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

• Any user with comment edit permission

[codecov]

Codecov Report

Attention: Patch coverage is 83.33333% with 6 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
gno.land/pkg/sdk/vm/keeper.go	81.81%	4 Missing and 2 partials ⚠️

📢 Thoughts on this report? Let us know!

[kristovatlas]

Great PR. Nice assortment of tests. Can confirm it prevents the following PoC from crashing the node when using gnokey maketx addpkg, and simply runs out of gas when using gnokey maketx call regardless of how much gas you provide:

package hello

func main() {
	for {
	}
	println("hello world")
}

func Main() {
	main()
}

[mvertes]

The code changes are fine and ok to me. They fix the issue but also simplify and clarify the implementation of gasmeter and panic handling. Great!

I have some remarks (outside of this PR) while reviewing the whole codepath related to CPU and gas accounting:

• in gnovm Machine struct, we still have a MaxCycles field which is redundant with gasmeter, but almost unused. It still generates some overhead at each opcode execution, we should get rid of it.
• There are still places in gas management where overflow check are missing.

I'm preparing a PR to fix those, independently of this PR.

[zivkovicmilos]

Looks solid 💯

[thehowl]

thanks folks!