-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add JJOptimist's Homepage realm to examples #3405
Conversation
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check comments 🙏
Apart from that, if you want to merge something into the examples/
folder, it should provide some educational value about Gno to newcomers. Please, explore a bit more and see what interesting realms or packages you can use to make your home realm more unique, so that it can be merged into the monorepo.
If you do not want to do this, you can simply deploy persmissionlessly.
Hey @JJOptimist, what's the status of this PR? |
I fixed the things you pointed out and took your suggestion to use ownable. Ive been experimenting to make something creative/ worth the HoF, so i will push it all together soon |
I've updated the realm
The gnome's expression changes based on block height divisibility (by 2, 3, 5, or 7) |
Generally, please take a look at comments and reply to them, even if they're outdated because you've changed the code completely. |
Thanks for your patience. Let me explain the code evolution: Initially, I tried to create an animated realm with CSS animations. However, I discovered that complex CSS animations weren't the best approach for a Gno realm, as:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start; please fix the things I mentioned in the comments below :)
I've updated the home realm:
|
Co-authored-by: Leon Hudak <33522493+leohhhn@users.noreply.github.com>
Co-authored-by: Leon Hudak <33522493+leohhhn@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just check the leftover comments, and run make fmt
in examples :)
Hey it seems you have a bit of an issue with the diff. Can you just have the files you're trying to add? After that we can merge. |
Removed from cache👍 |
This pull request adds a new realm example to the Gno examples repository—JJOptimist's Homepage.
The realm includes: