Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples): use std.GetChainDomain() #3293

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

moul
Copy link
Member

@moul moul commented Dec 6, 2024

  • ⚠️ TODO: decide if we keep tests.gno.land as the gno test domain
  • fix txlink etc to make valid remote links (missinghttps)

Related with #2911

Signed-off-by: moul <94029+moul@users.noreply.github.com>
@moul moul self-assigned this Dec 6, 2024
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Dec 6, 2024
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Dec 6, 2024

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: moul/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@moul moul changed the title chore: use chore(examples): use std.GetChainDomain() Dec 6, 2024
moul added 5 commits December 7, 2024 00:40
Signed-off-by: moul <94029+moul@users.noreply.github.com>
Signed-off-by: moul <94029+moul@users.noreply.github.com>
Signed-off-by: moul <94029+moul@users.noreply.github.com>
Signed-off-by: moul <94029+moul@users.noreply.github.com>
@moul
Copy link
Member Author

moul commented Jan 13, 2025

I am still considering whether to keep tests.gno.land as the Gno test domain. Additionally, I am thinking about what we should do now, rather than in the future, regarding domain names for the various existing and upcoming networks.

@thehowl
Copy link
Member

thehowl commented Jan 14, 2025

Well, for gno test, I think that imports should use the loader norman's working on; and that the name of the package being tested should be determined by gno.mod. So, not necessarily tests.gno.land, just configured by the user?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: 📥 Inbox
Status: Triage
Development

Successfully merging this pull request may close these issues.

3 participants