chore(gnokey): in maketx addpkg, change -deposit to -send

[leohhhn]

Description

Changes the deposit flag to send. I think this change makes sense from the consistency perspective. I've had multiple times happen where I'm trying to deploy something with some initial balance, trying -send, only realizing that it's -deposit in this case.

It's quite obvious that the send will go to the deployed realm's address, so I think it's a valid change.

Contributors' checklist...

• Added new tests, or not needed, or not feasible
• Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
• Updated the official documentation or not needed
• No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
• Added references to related issues and PRs
• Provided any useful hints for running manual tests

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

[jefft0]

@leohhhn, can you fix the failed CI tests?

[thehowl]

Can we wait to do this until we decide if we want to rename OrigSend to something like Deposit?

#1475

[leohhhn]

@jefft0

The CI has been failing lately due to Codecov, as you may have seen being discussed in the Signal group.

@thehowl, sure, makes sense. I'll move this to draft.

[jefft0]

Removed the review/triage-pending label because the original author changed this PR to draft. When it is ready, we can add the label again.

[github-actions]

This PR is stale because it has been open 3 months with no activity. Remove stale label or comment or this will be closed in 3 months.