-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(examples): Implement markdown package #2912
feat(examples): Implement markdown package #2912
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
It's heading in the right direction by avoiding HTML, unlike other recent PRs. However, the current implementation isn't complete or appealing enough for me yet, though it may be for others. I believe it makes sense to view this PR not as a UI framework proposal but as a minimal md library. This library can be used by you or anyone else to build various UI frameworks. I'm fine with that direction. Therefore, you should rename |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I provided some opinionated feedback. I believe the current library is similar to ufmt
and can be merged early, allowing us to improve it over time.
I would prefer if you renamed it to md
. Additionally, please create a demo realm to showcase its capabilities.
That said, I'm fine with merging early.
@moul I'm fine with merging this, but I'm hesitant about using the |
Can you move this code to your personal/company namespace? |
752ebf3 i've moved to my new house |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge and see how people use this lib; maybe it will need some iteration.
cc @moul
EDIT: awaiting some internal discussions; I'll remove the "don't merge" label after them.
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Hey @sunspirit99 Congrats, on completing a Gno bounty! We’ve reviewed your submission and will be merging your PR shortly. Your work falls under the ‘competing implementation’ bounty category (https://github.com/gnolang/bounties). The initial bounty is awarded for getting it working, if you could add some documentation or testing that would be even better. Please share your email, and I’ll get in touch. There’s a Part B to this bounty that you can compete for if you’re interested, an adoption bounty. We recommend:
If you demonstrate a complete tool, and user metrics and adoption, which is organic and verifiable, an additional adoption bounty may be on the table. Take a look at the bounty repo above for more details. Join a bi-weekly Wednesday call or Discord Gnome Spotlight to showcase your work, and find creative ways to attract users. |
From #2753
I keep this PR open to see if I am on the right approach. If it's suitable, I'll investigate to make further improvements and provide implementation examples in the
Render()
functions of some current demo realms to demonstrate the use of this packagecc @moul
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description