Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make txtar and Codecov play nice (upload coverage) #3085

Closed
zivkovicmilos opened this issue Nov 7, 2024 · 1 comment · Fixed by #3088
Closed

Make txtar and Codecov play nice (upload coverage) #3085

zivkovicmilos opened this issue Nov 7, 2024 · 1 comment · Fixed by #3088
Assignees
Labels
help wanted Want to contribute? We recommend these issues.

Comments

@zivkovicmilos
Copy link
Member

zivkovicmilos commented Nov 7, 2024

Description

Currently, the monorepo has an abundance of .txtar testing suites, but the code they cover is never uploaded or made aware to Codecov, causing the CI to fail on some PRs even though there is coverage.

This task involves making sure code covered with .txtar tests (which are ran from _test.go files) is visible in Codecov.

DoD:

  • CodeCov / go recognizes code ran by .txtar tests
  • .txtar code coverage is visible on the Codecov dashboard

Example PR:

@gfanton
Copy link
Member

gfanton commented Nov 8, 2024

After doing some checks, it appears that the current txtar implementation is correctly handling coverage. The only case where txtar could skip coverage is when it executes a binary in a separate process, where it loses track of coverage, but this has already been addressed (#1243).

The issue in #3003 is not related to txtar but rather to how Go generates coverage by default. See my comment #3003 (comment).

Closing this for now. Feel free to reopen it if you still think there is a problem related to txtar specifically.

@gfanton gfanton closed this as completed Nov 8, 2024
thehowl added a commit that referenced this issue Nov 8, 2024
Note: I'm uncertain about what will happen after the merge.

Fixes #3085 
Addresses #3003

---------

Signed-off-by: moul <94029+moul@users.noreply.github.com>
Co-authored-by: Morgan <morgan@morganbaz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Want to contribute? We recommend these issues.
Projects
Development

Successfully merging a pull request may close this issue.

2 participants