Update precompile metadata mainnet #519

beqaabu · 2024-11-05T11:35:33Z

Description of proposed changes

This pr tries to merge testnet changes into mainnet and additionally include updated precompile metadata json file for mainnet.

~~This pr will additionally require a version bump.~~

Practical tips for PR review & merge:

All GitHub Actions report PASS
Newly added code/functions have unit tests
- Coverage tools report all newly added lines as covered
- The positive scenario is exercised
- Negative scenarios are exercised, e.g. assert on all possible errors
- Assert on events triggered if applicable
- Assert on changes made to storage if applicable
Modified behavior/functions - try to make sure above test items are covered
Integration tests are added if applicable/needed

github-actions · 2024-11-05T11:55:09Z

For full LLVM coverage report click here!

atodorov

Some changes requested:

Get rid of the "Merge commit" if possible to keep the history linear
4fcee13 should also be cherry-picked on the rest of the branches.

This pr will additionally require a version bump.

Mainnet is currently on 3.32.0 while the new code is v3.35.0 so the version bumo is already there.

atodorov

https://github.com/gluwa/creditcoin3/actions/runs/11683355803/job/32532535295?pr=519 crashed with:

Error: Input("Error opening spec file main: No such file or directory (os error 2)")

RPC URLs don't need to change

b/c MacOS 11 is no longer available. See: gluwa/creditcoin#1687

was introduced in b10fcfe

these sections are orioginally from the upstream substrate-node-template and don't seem to be relevant to Creditcoin!

Bumps [micromatch](https://github.com/micromatch/micromatch) from 4.0.5 to 4.0.8. - [Release notes](https://github.com/micromatch/micromatch/releases) - [Changelog](https://github.com/micromatch/micromatch/blob/master/CHANGELOG.md) - [Commits](micromatch/micromatch@4.0.5...4.0.8) --- updated-dependencies: - dependency-name: micromatch dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>

* add mainnet shorthand * chore: add empty mainnet spec file for node to compile * chore: fmt

Bumps [oxsecurity/megalinter](https://github.com/oxsecurity/megalinter) from 7 to 8. - [Release notes](https://github.com/oxsecurity/megalinter/releases) - [Changelog](https://github.com/oxsecurity/megalinter/blob/main/CHANGELOG.md) - [Commits](oxsecurity/megalinter@v7...v8) --- updated-dependencies: - dependency-name: oxsecurity/megalinter dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [taiki-e/install-action](https://github.com/taiki-e/install-action) from 2.42.14 to 2.42.37. - [Release notes](https://github.com/taiki-e/install-action/releases) - [Changelog](https://github.com/taiki-e/install-action/blob/main/CHANGELOG.md) - [Commits](taiki-e/install-action@v2.42.14...v2.42.37) --- updated-dependencies: - dependency-name: taiki-e/install-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 5.3.2 to 5.4.2. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v5.4.2/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [tokio](https://github.com/tokio-rs/tokio) from 1.39.2 to 1.40.0. - [Release notes](https://github.com/tokio-rs/tokio/releases) - [Commits](tokio-rs/tokio@tokio-1.39.2...tokio-1.40.0) --- updated-dependencies: - dependency-name: tokio dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [clap](https://github.com/clap-rs/clap) from 4.5.13 to 4.5.16. - [Release notes](https://github.com/clap-rs/clap/releases) - [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md) - [Commits](clap-rs/clap@clap_complete-v4.5.13...clap_complete-v4.5.16) --- updated-dependencies: - dependency-name: clap dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

in order to reduce the number of open pull requests. See https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#groups Needed to update how sanity check scripts work as well.

see https://github.com/gluwa/creditcoin3/actions/runs/10850908844/job/30113422026 Introduced in #469

Bumps the all-dependencies group with 2 updates: [taiki-e/install-action](https://github.com/taiki-e/install-action) and [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request). Updates `taiki-e/install-action` from 2.42.37 to 2.44.3 - [Release notes](https://github.com/taiki-e/install-action/releases) - [Changelog](https://github.com/taiki-e/install-action/blob/main/CHANGELOG.md) - [Commits](taiki-e/install-action@v2.42.37...v2.44.3) Updates `peter-evans/create-pull-request` from 6 to 7 - [Release notes](https://github.com/peter-evans/create-pull-request/releases) - [Commits](peter-evans/create-pull-request@v6...v7) --- updated-dependencies: - dependency-name: taiki-e/install-action dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all-dependencies - dependency-name: peter-evans/create-pull-request dependency-type: direct:production update-type: version-update:semver-major dependency-group: all-dependencies ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 5.4.2 to 5.4.6. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/v5.4.6/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v5.4.6/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>

for more information, see https://pre-commit.ci

… 2 updates Bumps the prod-dependencies group with 2 updates in the / directory: [clap](https://github.com/clap-rs/clap) and [similar-asserts](https://github.com/mitsuhiko/similar-asserts). Updates `clap` from 4.5.16 to 4.5.17 - [Release notes](https://github.com/clap-rs/clap/releases) - [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md) - [Commits](clap-rs/clap@clap_complete-v4.5.16...clap_complete-v4.5.17) Updates `similar-asserts` from 1.5.0 to 1.6.0 - [Changelog](https://github.com/mitsuhiko/similar-asserts/blob/main/CHANGELOG.md) - [Commits](mitsuhiko/similar-asserts@1.5.0...1.6.0) --- updated-dependencies: - dependency-name: clap dependency-type: direct:production update-type: version-update:semver-patch dependency-group: prod-dependencies - dependency-name: similar-asserts dependency-type: direct:production update-type: version-update:semver-minor dependency-group: prod-dependencies ... Signed-off-by: dependabot[bot] <support@github.com>

…h 4 updates Bumps the dev-dependencies group with 3 updates in the /cli directory: [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin), [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) and [typescript](https://github.com/microsoft/TypeScript). Bumps the dev-dependencies group with 1 update in the /docs/smart-contract-development/with-hardhat directory: [typescript](https://github.com/microsoft/TypeScript). Bumps the dev-dependencies group with 2 updates in the /testing directory: [typescript](https://github.com/microsoft/TypeScript) and [hardhat](https://github.com/nomiclabs/hardhat). Updates `@typescript-eslint/eslint-plugin` from 5.62.0 to 8.6.0 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.6.0/packages/eslint-plugin) Updates `@typescript-eslint/parser` from 5.62.0 to 8.6.0 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.6.0/packages/parser) Updates `typescript` from 5.5.2 to 5.6.2 - [Release notes](https://github.com/microsoft/TypeScript/releases) - [Changelog](https://github.com/microsoft/TypeScript/blob/main/azure-pipelines.release.yml) - [Commits](microsoft/TypeScript@v5.5.2...v5.6.2) Updates `typescript` from 5.4.5 to 5.6.2 - [Release notes](https://github.com/microsoft/TypeScript/releases) - [Changelog](https://github.com/microsoft/TypeScript/blob/main/azure-pipelines.release.yml) - [Commits](microsoft/TypeScript@v5.5.2...v5.6.2) Updates `typescript` from 5.2.2 to 5.6.2 - [Release notes](https://github.com/microsoft/TypeScript/releases) - [Changelog](https://github.com/microsoft/TypeScript/blob/main/azure-pipelines.release.yml) - [Commits](microsoft/TypeScript@v5.5.2...v5.6.2) Updates `hardhat` from 2.18.2 to 2.22.10 - [Release notes](https://github.com/nomiclabs/hardhat/releases) - [Commits](https://github.com/nomiclabs/hardhat/compare/hardhat@2.18.2...hardhat@2.22.10) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-major dependency-group: dev-dependencies - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-major dependency-group: dev-dependencies - dependency-name: typescript dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: typescript dependency-type: indirect update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: typescript dependency-type: indirect update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: hardhat dependency-type: indirect update-type: version-update:semver-minor dependency-group: dev-dependencies ... Signed-off-by: dependabot[bot] <support@github.com>

https://typescript-eslint.io/rules/ban-types/

https://typescript-eslint.io/rules/no-require-imports/

Bumps [rollup](https://github.com/rollup/rollup) from 4.21.2 to 4.22.4. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](rollup/rollup@v4.21.2...v4.22.4) --- updated-dependencies: - dependency-name: rollup dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>

beqaabu · 2024-11-05T12:27:40Z

https://github.com/gluwa/creditcoin3/actions/runs/11683355803/job/32532535295?pr=519 crashed with:

Error: Input("Error opening spec file main: No such file or directory (os error 2)")

I think thit error is fine on this branch because we don't have the mainnet spec file here (file was too large and we decided to keep it only on the main branch). It will be able to find that file as soon as this pr is merged into main

atodorov · 2024-11-05T13:00:13Z

file was too large and we decided to keep it only on the main branch

FTR this decision breaks runtime upgrade testing which will not be executed against mainnet data.

atodorov

✔️ Merge commit is gone
🎶 Last commit can be cherry-picked into other branches independently of this PR
⚠️ Runtime upgrade testing won't be executed, see Update precompile metadata mainnet #519 (comment)

beqaabu requested review from atodorov, DylanVerstraete, BradleyOlson64 and rustlang-dev November 5, 2024 12:08

atodorov requested changes Nov 5, 2024

View reviewed changes

atodorov and others added 23 commits November 5, 2024 16:24

Update boot node for Mainnet

785ba87

RPC URLs don't need to change

Use MacOS-13 runners for release

448499d

b/c MacOS 11 is no longer available. See: gluwa/creditcoin#1687

Add error checks for REGISTRATION_TOKEN

cc99de2

Specify missing OWNER_REPO_SLUG value for runtime upgrade CI jobs

9a4b29f

was introduced in b10fcfe

Remove README sections with dead URLs

e6da3de

these sections are orioginally from the upstream substrate-node-template and don't seem to be relevant to Creditcoin!

CSUB-1259 add mainnet shorthand (#452)

7182587

* add mainnet shorthand * chore: add empty mainnet spec file for node to compile * chore: fmt

Bump version to 3.33.0

dcdc8d0

Enable PR groupping for github-actions & docker updates too

90a21c5

Fix-up dependabot.yml config

1413cd3

see https://github.com/gluwa/creditcoin3/actions/runs/10850908844/job/30113422026 Introduced in #469

fix: correct precompile interface and json abi

ac71619

chore: resolve issues

6e76a19

[pre-commit.ci] auto fixes from pre-commit.com hooks

5baa714

for more information, see https://pre-commit.ci

chore: update json files

412cb4d

[pre-commit.ci] auto fixes from pre-commit.com hooks

fd8ce38

for more information, see https://pre-commit.ci

DylanVerstraete and others added 20 commits November 5, 2024 16:24

fix: update code and metadata files

73c9cdc

[pre-commit.ci] auto fixes from pre-commit.com hooks

e9edd08

for more information, see https://pre-commit.ci

chore: more updates

8ea316c

[pre-commit.ci] auto fixes from pre-commit.com hooks

4e0aada

for more information, see https://pre-commit.ci

fix: correct metadata

2f72412

fix: correct metadata

3401e93

[pre-commit.ci] auto fixes from pre-commit.com hooks

774c3b5

for more information, see https://pre-commit.ci

fix: correct metadata agai

9f89240

chore: bump version

265c591

Bump versio to 3.35.0

a54e039

Replace ban-types rule with new rule introduced in typescript-eslint v8

03ee988

https://typescript-eslint.io/rules/ban-types/

Rename unised variables

5083c48

Disable a linter error b/c it is false positive

d77c8eb

Resolve no-require-imports offences

d027805

https://typescript-eslint.io/rules/no-require-imports/

Enable metadata comparisons with Testnet & Mainnet

f00eecb

feat: update sudo for a new dryrun

d357fda

feat: update mainnet precompile metadata

c137d7c

beqaabu force-pushed the update-precompile-metadata-mainnet branch from 6b9c0bc to c137d7c Compare November 5, 2024 12:26

beqaabu requested a review from atodorov November 5, 2024 12:57

atodorov approved these changes Nov 5, 2024

View reviewed changes

BradleyOlson64 approved these changes Nov 5, 2024

View reviewed changes

DylanVerstraete approved these changes Nov 6, 2024

View reviewed changes

beqaabu merged commit 5c4a42e into main Nov 6, 2024
55 of 56 checks passed

beqaabu deleted the update-precompile-metadata-mainnet branch November 6, 2024 10:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update precompile metadata mainnet #519

Update precompile metadata mainnet #519

beqaabu commented Nov 5, 2024 •

edited

Loading

github-actions bot commented Nov 5, 2024

atodorov left a comment

atodorov left a comment •

edited

Loading

beqaabu commented Nov 5, 2024 •

edited

Loading

atodorov commented Nov 5, 2024

atodorov left a comment

Update precompile metadata mainnet #519

Update precompile metadata mainnet #519

Conversation

beqaabu commented Nov 5, 2024 • edited Loading

Description of proposed changes

github-actions bot commented Nov 5, 2024

atodorov left a comment

Choose a reason for hiding this comment

atodorov left a comment • edited Loading

Choose a reason for hiding this comment

beqaabu commented Nov 5, 2024 • edited Loading

atodorov commented Nov 5, 2024

atodorov left a comment

Choose a reason for hiding this comment

beqaabu commented Nov 5, 2024 •

edited

Loading

atodorov left a comment •

edited

Loading

beqaabu commented Nov 5, 2024 •

edited

Loading