Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSUB-1219: Enable metadata comparisons with Testnet & Mainnet #499

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

atodorov
Copy link
Contributor

Description of proposed changes


Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

Copy link

For full LLVM coverage report click here!

@atodorov atodorov marked this pull request as ready for review September 25, 2024 12:28
@atodorov atodorov requested a review from a team as a code owner September 25, 2024 12:28
@atodorov atodorov requested review from dave1374, dlebee, DylanVerstraete, BradleyOlson64, beqaabu and rustlang-dev and removed request for a team, dave1374 and dlebee September 25, 2024 12:28
@atodorov atodorov merged commit 7f88e06 into dev Sep 26, 2024
53 checks passed
@atodorov atodorov deleted the testing/CSUB-1219-metadata-compare-mainnet branch September 26, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants