Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run of Subcommand::FrontierDb inside node #479

Merged
merged 2 commits into from
Sep 16, 2024
Merged

fix: run of Subcommand::FrontierDb inside node #479

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63d9c7f
fix run of Subcommand::FrontierDb
rustlang-dev Sep 16, 2024
a0835ea
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions node/src/command.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,11 +240,10 @@ pub fn run() -> sc_cli::Result<()> {
let (client, _, _, _, frontier_backend) =
service::new_chain_ops(&mut config, &cli.eth)?;
let frontier_backend = match frontier_backend {
fc_db::Backend::KeyValue(kv) => std::sync::Arc::new(kv),
fc_db::Backend::KeyValue(kv) => kv,
_ => panic!("Only fc_db::Backend::KeyValue supported"),
};
// cmd.run(client, *frontier_backend)
todo!();// ^ uncomment this line
cmd.run(client, frontier_backend)
})
}
None => {
Expand Down
3 changes: 1 addition & 2 deletions node/src/service.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,7 +475,7 @@ where
let warp_sync_params = if sealing.is_some() {
None
} else {

net_config.add_notification_protocol(grandpa_protocol_config);
let warp_sync: Arc<dyn WarpSyncProvider<Block>> =
Arc::new(sc_consensus_grandpa::warp_proof::NetworkProvider::new(
Expand Down Expand Up @@ -807,7 +807,6 @@ where
// and vote data availability than the observer. The observer has not
// been tested extensively yet and having most nodes in a network run it
// could lead to finality stalls.
todo!();
let grandpa_voter =
sc_consensus_grandpa::run_grandpa_voter(sc_consensus_grandpa::GrandpaParams {
config: grandpa_config,
Expand Down
Loading