Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use consistent names for binary inside/outside of container #160

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

atodorov
Copy link
Contributor

@atodorov atodorov commented Jan 8, 2024

rename the container entrypoint to creditcoin3-node!

Description of proposed changes


Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

Copy link

github-actions bot commented Jan 8, 2024

For full LLVM coverage report click here!

@frankli-dev
Copy link
Contributor

LGTM

rename the container entrypoint to creditcoin3-node!
@atodorov atodorov merged commit e58a194 into dev Jan 8, 2024
26 checks passed
@atodorov atodorov deleted the update_dockerfile branch January 8, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants