Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSUB-1071: Update to Rustc 1.77.0 #159

Merged
merged 4 commits into from
Apr 25, 2024
Merged

CSUB-1071: Update to Rustc 1.77.0 #159

merged 4 commits into from
Apr 25, 2024

Conversation

atodorov
Copy link
Contributor

@atodorov atodorov commented Jan 8, 2024

Description of proposed changes

Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

@atodorov atodorov mentioned this pull request Jan 8, 2024
Merged
9 tasks
@atodorov atodorov changed the title Update to Rustc 1.75.0 Update to Rustc 1.74.0 Jan 8, 2024
@atodorov atodorov force-pushed the update_rustc_version branch from 0621bf0 to 4cbe245 Compare January 8, 2024 10:25
@atodorov atodorov marked this pull request as draft January 8, 2024 12:50
@atodorov atodorov force-pushed the update_rustc_version branch from 4cbe245 to 1ea686a Compare January 8, 2024 15:40
atodorov
atodorov commented Jan 8, 2024
View reviewed changes
Copy link
Contributor Author

@atodorov atodorov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

llvm test coverage job fails with:

error: Failed to load coverage: 'target/llvm-cov-target/debug/deps/creditcoin3_runtime-c33f915af65158f7': Malformed coverage data

https://github.com/gluwa/creditcoin3/actions/runs/7449714889/job/20266965619?pr=159, not sure why that is!

Appears to be rust-lang/rust#117788 (comment)

@atodorov atodorov force-pushed the update_rustc_version branch from 1ea686a to 92f2625 Compare January 18, 2024 17:32
@atodorov atodorov force-pushed the update_rustc_version branch from 92f2625 to b8fdb9d Compare February 23, 2024 11:48
@atodorov atodorov changed the title Update to Rustc 1.74.0 Update to Rustc 1.75.0 Feb 23, 2024
@atodorov atodorov force-pushed the update_rustc_version branch from b8fdb9d to bd5b40a Compare March 1, 2024 14:07
@atodorov atodorov mentioned this pull request Mar 6, 2024
Closed
@atodorov atodorov changed the title Update to Rustc 1.75.0 CSUB-1071: Update to Rustc 1.75.0 Mar 8, 2024
@atodorov atodorov force-pushed the update_rustc_version branch from bd5b40a to 3921768 Compare March 8, 2024 11:22
@atodorov atodorov mentioned this pull request Mar 8, 2024
Merged
9 tasks
@atodorov
Copy link
Contributor Author

atodorov commented Mar 8, 2024

FTR the latest failure we're seeing is rust-lang/rust#119453 which is fixed in 1.77.0 which will be released into the stable stream on March 21. Will wait 2 weeks and upgrade.

@woosungchoi
Copy link

FTR the latest failure we're seeing is rust-lang/rust#119453 which is fixed in 1.77.0 which will be released into the stable stream on March 21. Will wait 2 weeks and upgrade.

https://github.com/rust-lang/rust/releases/tag/1.77.0

Released!

@atodorov atodorov force-pushed the update_rustc_version branch from 3921768 to 0c3a2f3 Compare March 22, 2024 11:07
@github-actions GitHub Actions
Copy link

For full LLVM coverage report click here!

@atodorov atodorov changed the title CSUB-1071: Update to Rustc 1.75.0 CSUB-1071: Update to Rustc 1.77.0 Mar 22, 2024
This was referenced Apr 2, 2024
Merged
Merged
@atodorov
Copy link
Contributor Author

atodorov commented Apr 2, 2024

Needs paritytech/srtool 1.77.0, latest one is 1.75.0 -> https://hub.docker.com/r/paritytech/srtool/tags

@woosungchoi
Copy link

woosungchoi commented Apr 23, 2024 •
edited
Loading

Needs paritytech/srtool 1.77.0, latest one is 1.75.0 -> https://hub.docker.com/r/paritytech/srtool/tags

https://hub.docker.com/layers/paritytech/srtool/1.77.0/images/sha256-07ac3252fe06aa6dc39bd9dc5c558ceaeaea17dd9b9389990618d3bcede2513f?context=explore

1.77.0 Released!

@atodorov
Update to Rustc 1.74.0
650ffa5 
b/c paritytech/srtool doesn't provide a later image
@atodorov atodorov force-pushed the update_rustc_version branch from 0c3a2f3 to bfee280 Compare April 23, 2024 08:24
@atodorov atodorov marked this pull request as ready for review April 23, 2024 08:24
@atodorov atodorov requested a review from a team as a code owner April 23, 2024 08:24
@atodorov atodorov requested review from dave1374 and removed request for a team, pLabarta and nathanwhit April 23, 2024 08:24
@atodorov atodorov mentioned this pull request Apr 23, 2024
Closed
@atodorov atodorov merged commit d85c206 into dev Apr 25, 2024
37 checks passed
@atodorov atodorov deleted the update_rustc_version branch April 25, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beqaabu beqaabu beqaabu approved these changes

@zacharyfrederick zacharyfrederick zacharyfrederick left review comments

@DylanVerstraete DylanVerstraete Awaiting requested review from DylanVerstraete

@gaquarius gaquarius Awaiting requested review from gaquarius

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@atodorov @woosungchoi @zacharyfrederick @beqaabu