Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CSUB-984] Fix CLI "lookup index" warning #153

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Conversation

pLabarta
Copy link
Contributor

@pLabarta pLabarta commented Jan 3, 2024

Description of proposed changes

Fixed by bumping the polkadot/api version: https://github.com/polkadot-js/api/releases/tag/v10.11.2


Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

Copy link

github-actions bot commented Jan 3, 2024

For full LLVM coverage report click here!

@pLabarta pLabarta marked this pull request as ready for review January 3, 2024 17:38
@pLabarta pLabarta force-pushed the 984-cli-fix-warning branch from 38c3efe to 8ff6af3 Compare January 3, 2024 18:51
@pLabarta pLabarta force-pushed the 984-cli-fix-warning branch from 2909f8e to 0ed461c Compare January 4, 2024 19:05
@pLabarta pLabarta merged commit 140ce44 into dev Jan 4, 2024
26 checks passed
@pLabarta pLabarta deleted the 984-cli-fix-warning branch January 4, 2024 20:46
@atodorov atodorov changed the title [CSUB 984] Fix CLI "lookup index" warning [CSUB-984] Fix CLI "lookup index" warning Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants