Skip to content

Commit

Permalink
Merge pull request #479 from gluwa/fix-run-subcommand-frontierdb
Browse files Browse the repository at this point in the history
fix: run of Subcommand::FrontierDb inside node
  • Loading branch information
rustlang-dev authored Sep 16, 2024
2 parents d2bcdd7 + a0835ea commit b235b8f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
5 changes: 2 additions & 3 deletions node/src/command.rs
Original file line number Diff line number Diff line change
Expand Up @@ -240,11 +240,10 @@ pub fn run() -> sc_cli::Result<()> {
let (client, _, _, _, frontier_backend) =
service::new_chain_ops(&mut config, &cli.eth)?;
let frontier_backend = match frontier_backend {
fc_db::Backend::KeyValue(kv) => std::sync::Arc::new(kv),
fc_db::Backend::KeyValue(kv) => kv,
_ => panic!("Only fc_db::Backend::KeyValue supported"),
};
// cmd.run(client, *frontier_backend)
todo!();// ^ uncomment this line
cmd.run(client, frontier_backend)
})
}
None => {
Expand Down
3 changes: 1 addition & 2 deletions node/src/service.rs
Original file line number Diff line number Diff line change
Expand Up @@ -475,7 +475,7 @@ where
let warp_sync_params = if sealing.is_some() {
None
} else {

net_config.add_notification_protocol(grandpa_protocol_config);
let warp_sync: Arc<dyn WarpSyncProvider<Block>> =
Arc::new(sc_consensus_grandpa::warp_proof::NetworkProvider::new(
Expand Down Expand Up @@ -807,7 +807,6 @@ where
// and vote data availability than the observer. The observer has not
// been tested extensively yet and having most nodes in a network run it
// could lead to finality stalls.
todo!();
let grandpa_voter =
sc_consensus_grandpa::run_grandpa_voter(sc_consensus_grandpa::GrandpaParams {
config: grandpa_config,
Expand Down

0 comments on commit b235b8f

Please sign in to comment.