CSUB-312: Conditionally panic! in migrations when testing

[atodorov]

so that future tests would crash if unexpected situations happen and we would have to inspect the crashes and figure out how to deal with potential corner cases

@nathanwhit, @CAGS295 - what would happen if even despite tests such panic happens when migrating a mainnet node ?

[github-actions]

For full LLVM coverage report click here!

[CAGS295]

I haven't explored yet what happens under panics. We need to consider what happens when the scheduled upgrade fails. I suggest having a feature option for testing and otherwise never panic.

[nathanwhit]

If the migration panics, the chain is effectively bricked. No new blocks will be produced, and the only "fix" is to get a majority of the network to revert the block that triggered the update.

So yeah, I agree with Carlos. If we do want it to panic on failure, the panic should be gated for testing.

[atodorov]

Failing job in CI if we're using log::warn! directly instead of the warn_or_panic! - https://github.com/gluwa/creditcoin/actions/runs/3744124997/jobs/6357132834

PASS -> https://github.com/gluwa/creditcoin/actions/runs/3744195353/jobs/6357285397 after the current changes.

[codecov-commenter]

Codecov Report

Merging #820 (234c82b) into dev (80ed87a) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##              dev     #820   +/-   ##
=======================================
  Coverage   78.05%   78.05%           
=======================================
  Files          66       66           
  Lines       10609    10609           
=======================================
  Hits         8281     8281           
  Misses       2328     2328           

Impacted Files	Coverage Δ
pallets/creditcoin/src/lib.rs	81.70% <ø> (ø)
pallets/creditcoin/src/migrations/v6.rs	89.21% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more