-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSUB-348 Simplify associated signing types #815
Conversation
For full LLVM coverage report click here! |
Codecov Report
@@ Coverage Diff @@
## dev #815 +/- ##
==========================================
- Coverage 78.06% 78.05% -0.02%
==========================================
Files 66 66
Lines 10601 10609 +8
==========================================
+ Hits 8276 8281 +5
- Misses 2325 2328 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
blocked by #813 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes requested.
39a634f
to
d3be99b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
d3be99b
to
9ea3c66
Compare
499db41
to
482410c
Compare
Description of proposed changes:
Get rid of some associated types that were used as intermediate types between authority key selection and offchain-worker signing.
This may not be final but, the changes are in the right direction.
Practical tips for PR review & merge: